Re: [Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design

2015-09-23 Thread Daniel P. Berrange
On Tue, Sep 22, 2015 at 05:35:59PM +0100, Daniel P. Berrange wrote: > Developers who are new to QEMU, or have a background familiarity > with GNU autotools can have trouble getting their head around the > home-grown QEMU build system. This document attempts to explain > the structure / design of th

Re: [Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design

2015-09-22 Thread Paolo Bonzini
On 22/09/2015 20:11, John Snow wrote: >> +such as error handling infrastructure, standard data structures, >> +platform portability wrapper functions, etc. This code can be compiled >> +once only and the .o files linked into all output binaries. >> + >> +In the target dependant set lives CPU emul

Re: [Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design

2015-09-22 Thread Laszlo Ersek
On 09/22/15 20:51, Eric Blake wrote: > On 09/22/2015 12:28 PM, Laszlo Ersek wrote: >> meta review of your review: >> > >> +Each system/userspace emulation target needs to have a slightly +different set of make rules / variables. Thus, make will be recursively +invoked for each of th

Re: [Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design

2015-09-22 Thread Eric Blake
On 09/22/2015 12:28 PM, Laszlo Ersek wrote: > meta review of your review: > > >>> +Each system/userspace emulation target needs to have a slightly >>> +different set of make rules / variables. Thus, make will be recursively >>> +invoked for each of the emulation targets. >>> + >>> +The recursive

Re: [Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design

2015-09-22 Thread Laszlo Ersek
meta review of your review: On 09/22/15 20:11, John Snow wrote: > Reviewed from an en_US perspective, though I left alone things that are > clearly regional (e.g. 'behaviour' vs 'behavior') > > On 09/22/2015 12:35 PM, Daniel P. Berrange wrote: >> + - Add information to the help output message to

Re: [Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design

2015-09-22 Thread Eric Blake
On 09/22/2015 10:35 AM, Daniel P. Berrange wrote: > Developers who are new to QEMU, or have a background familiarity > with GNU autotools can have trouble getting their head around the s/autotools/autotools,/ > home-grown QEMU build system. This document attempts to explain > the structure / desi

Re: [Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design

2015-09-22 Thread Laszlo Ersek
On 09/22/15 18:35, Daniel P. Berrange wrote: > Developers who are new to QEMU, or have a background familiarity > with GNU autotools can have trouble getting their head around the > home-grown QEMU build system. This document attempts to explain > the structure / design of the configure script and

Re: [Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design

2015-09-22 Thread John Snow
Reviewed from an en_US perspective, though I left alone things that are clearly regional (e.g. 'behaviour' vs 'behavior') On 09/22/2015 12:35 PM, Daniel P. Berrange wrote: > Developers who are new to QEMU, or have a background familiarity > with GNU autotools can have trouble getting their head ar

[Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design

2015-09-22 Thread Daniel P. Berrange
Developers who are new to QEMU, or have a background familiarity with GNU autotools can have trouble getting their head around the home-grown QEMU build system. This document attempts to explain the structure / design of the configure script and the various Makefile pieces that live across the sour