Re: [Qemu-devel] [PATCH] docs: document how to use the l2-cache-entry-size parameter

2018-02-22 Thread Alberto Garcia
On Thu 22 Feb 2018 03:17:57 PM CET, Kevin Wolf wrote: >> > While we're at it, would l2-cache-entry-size = MIN(cluster_size, >> > 64k) make sense as a default? >> >> Any reason why you choose 64k, or is it because it's the default >> cluster size? >> >> In general I'd be cautious to reduce the def

Re: [Qemu-devel] [PATCH] docs: document how to use the l2-cache-entry-size parameter

2018-02-22 Thread Kevin Wolf
Am 22.02.2018 um 14:06 hat Alberto Garcia geschrieben: > On Wed 21 Feb 2018 07:33:55 PM CET, Kevin Wolf wrote: > > [docs/qcow2-cache.txt] > > While reviewing this, I read the whole document and stumbled across > > these paragraphs: > > > >> The reason for this 1/4 ratio is to ensure that both cac

Re: [Qemu-devel] [PATCH] docs: document how to use the l2-cache-entry-size parameter

2018-02-22 Thread Alberto Garcia
On Wed 21 Feb 2018 07:33:55 PM CET, Kevin Wolf wrote: [docs/qcow2-cache.txt] > While reviewing this, I read the whole document and stumbled across > these paragraphs: > >> The reason for this 1/4 ratio is to ensure that both caches cover the >> same amount of disk space. Note however that this is

Re: [Qemu-devel] [PATCH] docs: document how to use the l2-cache-entry-size parameter

2018-02-21 Thread Kevin Wolf
Am 19.02.2018 um 15:54 hat Alberto Garcia geschrieben: > This patch updates docs/qcow2-cache.txt explaining how to use the new > l2-cache-entry-size parameter. > > Here's a more detailed technical description of this feature: > >https://lists.gnu.org/archive/html/qemu-block/2017-09/msg00635.h

Re: [Qemu-devel] [PATCH] docs: document how to use the l2-cache-entry-size parameter

2018-02-19 Thread Eric Blake
On 02/19/2018 12:26 PM, Alberto Garcia wrote: + - The L2 cache entry size has the same restrictions as the cluster + size (power of two, at least 512 bytes). Worth mentioning the upper limit of the cluster size? I thought it would be unnecessary since the that's already mentioned several t

Re: [Qemu-devel] [PATCH] docs: document how to use the l2-cache-entry-size parameter

2018-02-19 Thread Alberto Garcia
On Mon 19 Feb 2018 05:44:23 PM CET, Eric Blake wrote: > On 02/19/2018 08:54 AM, Alberto Garcia wrote: >> This patch updates docs/qcow2-cache.txt explaining how to use the new >> l2-cache-entry-size parameter. >> >> Here's a more detailed technical description of this feature: >> >> https://l

Re: [Qemu-devel] [PATCH] docs: document how to use the l2-cache-entry-size parameter

2018-02-19 Thread Eric Blake
On 02/19/2018 08:54 AM, Alberto Garcia wrote: This patch updates docs/qcow2-cache.txt explaining how to use the new l2-cache-entry-size parameter. Here's a more detailed technical description of this feature: https://lists.gnu.org/archive/html/qemu-block/2017-09/msg00635.html And here are

[Qemu-devel] [PATCH] docs: document how to use the l2-cache-entry-size parameter

2018-02-19 Thread Alberto Garcia
This patch updates docs/qcow2-cache.txt explaining how to use the new l2-cache-entry-size parameter. Here's a more detailed technical description of this feature: https://lists.gnu.org/archive/html/qemu-block/2017-09/msg00635.html And here are some performance numbers: https://lists.gnu.o