On Sat, Feb 25, 2012 at 02:50:25PM +0100, Stefan Weil wrote:
> Without the break statement, case 5 sets month and year from the same
> data. This does not look correct.
>
> The missing break was reported by splint.
>
> Signed-off-by: Stefan Weil
> ---
> hw/ds1338.c |1 +
> 1 files changed,
Am 25.02.2012 14:50, schrieb Stefan Weil:
> Without the break statement, case 5 sets month and year from the same
> data. This does not look correct.
>
> The missing break was reported by splint.
>
> Signed-off-by: Stefan Weil
Assigning data to both month and year certainly makes no sense,
Rev
Am 25.02.2012 14:50, schrieb Stefan Weil:
Without the break statement, case 5 sets month and year from the same
data. This does not look correct.
The missing break was reported by splint.
Signed-off-by: Stefan Weil
---
hw/ds1338.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --
On 25 February 2012 13:50, Stefan Weil wrote:
> Without the break statement, case 5 sets month and year from the same
> data. This does not look correct.
Yep, looks like a simple missing break, checked against the
datasheet at http://datasheets.maxim-ic.com/en/ds/DS1338-DS1338Z.pdf
Reviewed-by:
Without the break statement, case 5 sets month and year from the same
data. This does not look correct.
The missing break was reported by splint.
Signed-off-by: Stefan Weil
---
hw/ds1338.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/ds1338.c b/hw/ds1338.c
index 6
