Re: [Qemu-devel] [PATCH] e1000: Avoid infinite loop in processing transmit descriptor

2015-09-09 Thread pjp
Hello Stefan, > On Wednesday, 9 September 2015 2:40 PM, Stefan Hajnoczi wrote: > P J P probably chose this approach because it is the smallest > change. True. > On Wednesday, 9 September 2015 2:40 PM, Stefan Hajnoczi wrote: >> hw/net/e1000.c | 3 ++- >> 1 file changed, 2 insertions(+), 1

Re: [Qemu-devel] [PATCH] e1000: Avoid infinite loop in processing transmit descriptor

2015-09-09 Thread Stefan Hajnoczi
On Fri, Sep 04, 2015 at 05:21:06PM +0100, Stefan Hajnoczi wrote: > From: P J P > > While processing transmit descriptors, it could lead to an infinite > loop if 'bytes' was to become zero; Add a check to avoid it. > > [The guest can force 'bytes' to 0 by setting the hdr_len and mss > descriptor

Re: [Qemu-devel] [PATCH] e1000: Avoid infinite loop in processing transmit descriptor

2015-09-09 Thread Stefan Hajnoczi
On Mon, Sep 07, 2015 at 11:04:47AM +0200, Thomas Huth wrote: > On 04/09/15 18:21, Stefan Hajnoczi wrote: > > From: P J P > > > > While processing transmit descriptors, it could lead to an infinite > > loop if 'bytes' was to become zero; Add a check to avoid it. > > > > [The guest can force 'byte

Re: [Qemu-devel] [PATCH] e1000: Avoid infinite loop in processing transmit descriptor

2015-09-07 Thread Thomas Huth
On 04/09/15 18:21, Stefan Hajnoczi wrote: > From: P J P > > While processing transmit descriptors, it could lead to an infinite > loop if 'bytes' was to become zero; Add a check to avoid it. > > [The guest can force 'bytes' to 0 by setting the hdr_len and mss > descriptor fields to 0. > --Stefan

[Qemu-devel] [PATCH] e1000: Avoid infinite loop in processing transmit descriptor

2015-09-04 Thread Stefan Hajnoczi
From: P J P While processing transmit descriptors, it could lead to an infinite loop if 'bytes' was to become zero; Add a check to avoid it. [The guest can force 'bytes' to 0 by setting the hdr_len and mss descriptor fields to 0. --Stefan] Signed-off-by: P J P Signed-off-by: Stefan Hajnoczi -