Re: [Qemu-devel] [PATCH] e1000: Don't set the Capabilities List bit

2012-10-19 Thread Philipp Hahn
Hello, On Friday 19 October 2012 11:59:24 Philipp Hahn wrote: > On Wednesday 21 September 2011 22:06:25 dann frazier wrote: ... > > -/* TODO: we have no capabilities, so why is this bit set? */ > > -pci_set_word(pci_conf + PCI_STATUS, PCI_STATUS_CAP_LIST); ... > Since cmask[PCI_STATUS=6] =

Re: [Qemu-devel] [PATCH] e1000: Don't set the Capabilities List bit

2012-10-19 Thread Philipp Hahn
Hello, On Wednesday 21 September 2011 22:06:25 dann frazier wrote: > The Capabilities Pointer is NULL, so this bit shouldn't be set. The state > of this bit doesn't appear to change any behavior on Linux/Windows versions > we've tested, but it does cause Windows' PCI/PCI Express Compliance Test to

Re: [Qemu-devel] [PATCH] e1000: Don't set the Capabilities List bit

2011-09-23 Thread Anthony Liguori
On 09/21/2011 03:06 PM, dann frazier wrote: [Originally sent to qemu-kvm list, but I was redirected here] The Capabilities Pointer is NULL, so this bit shouldn't be set. The state of this bit doesn't appear to change any behavior on Linux/Windows versions we've tested, but it does cause Windows'

[Qemu-devel] [PATCH] e1000: Don't set the Capabilities List bit

2011-09-21 Thread dann frazier
[Originally sent to qemu-kvm list, but I was redirected here] The Capabilities Pointer is NULL, so this bit shouldn't be set. The state of this bit doesn't appear to change any behavior on Linux/Windows versions we've tested, but it does cause Windows' PCI/PCI Express Compliance Test to balk. I h