Hi,
>>
>> Missing braces, please use checkpatch.pl.
>>
>
> Oops, Gerd since this is already in your tree, can you fix this, or do you
> want a new fixed version ?
I've already fixed it.
You can wire checkpatch.pl into the git commit hook to avoid those slip
through unnoticed.
cheers,
Gerd
Hi,
Sorry.
On 09/22/2012 03:16 PM, Blue Swirl wrote:
On Thu, Sep 20, 2012 at 3:38 PM, Hans de Goede wrote:
@@ -1837,6 +1838,10 @@ static EHCIQueue *ehci_state_fetchqh(EHCIState *ehci,
int async)
}
q->qh = qh;
+q->transact_ctr = get_field(q->qh.epcap, QH_EPCAP_MULT);
+
On Thu, Sep 20, 2012 at 3:38 PM, Hans de Goede wrote:
> There are several issues with our handling of the MULT epcap field
> of interrupt qhs, which this patch fixes.
>
> 1) When we don't execute a transaction because of the transaction counter
> being 0, p->async stays EHCI_ASYNC_NONE, and the ne
On 09/20/12 17:38, Hans de Goede wrote:
> There are several issues with our handling of the MULT epcap field
> of interrupt qhs, which this patch fixes.
Patch added to usb patch queue.
thanks,
Gerd
There are several issues with our handling of the MULT epcap field
of interrupt qhs, which this patch fixes.
1) When we don't execute a transaction because of the transaction counter
being 0, p->async stays EHCI_ASYNC_NONE, and the next time we process the
same qtd we hit an assert in ehci_state_f
