Re: [Qemu-devel] [PATCH] etsec: fix IRQ (un)masking

2018-07-08 Thread David Gibson
On Sat, Jul 07, 2018 at 11:06:05AM -0700, Michael Davidsaver wrote: > On 11/28/2017 05:35 PM, David Gibson wrote: > > On Mon, Nov 27, 2017 at 08:42:13PM -0600, Michael Davidsaver wrote: > >> Interrupt conditions occurring while masked are not being > >> signaled when later unmasked. > >> The fix is

Re: [Qemu-devel] [PATCH] etsec: fix IRQ (un)masking

2018-07-07 Thread Michael Davidsaver
On 11/28/2017 05:35 PM, David Gibson wrote: > On Mon, Nov 27, 2017 at 08:42:13PM -0600, Michael Davidsaver wrote: >> Interrupt conditions occurring while masked are not being >> signaled when later unmasked. >> The fix is to raise/lower IRQs when IMASK is changed. >> >> To avoid problems like this

Re: [Qemu-devel] [PATCH] etsec: fix IRQ (un)masking

2017-11-28 Thread David Gibson
On Mon, Nov 27, 2017 at 08:42:13PM -0600, Michael Davidsaver wrote: > Interrupt conditions occurring while masked are not being > signaled when later unmasked. > The fix is to raise/lower IRQs when IMASK is changed. > > To avoid problems like this in future, consolidate > IRQ pin update logic in o

[Qemu-devel] [PATCH] etsec: fix IRQ (un)masking

2017-11-27 Thread Michael Davidsaver
Interrupt conditions occurring while masked are not being signaled when later unmasked. The fix is to raise/lower IRQs when IMASK is changed. To avoid problems like this in future, consolidate IRQ pin update logic in one function. Also fix probable typo "IEVENT_TXF | IEVENT_TXF", and update IRQ p