Re: [Qemu-devel] [PATCH] file-posix: add drop-cache=on|off option

2019-02-27 Thread Stefan Hajnoczi
On Wed, Feb 27, 2019 at 03:56:27PM +, Daniel P. Berrangé wrote: > On Wed, Feb 27, 2019 at 03:33:11PM +, Stefan Hajnoczi wrote: > > On Tue, Feb 26, 2019 at 10:54:55AM -0600, Eric Blake wrote: > > > On 2/26/19 9:35 AM, Stefan Hajnoczi wrote: > > > > Commit dd577a26ff03b6829721b1ffbbf9e7c411b7

Re: [Qemu-devel] [PATCH] file-posix: add drop-cache=on|off option

2019-02-27 Thread Daniel P . Berrangé
On Wed, Feb 27, 2019 at 03:33:11PM +, Stefan Hajnoczi wrote: > On Tue, Feb 26, 2019 at 10:54:55AM -0600, Eric Blake wrote: > > On 2/26/19 9:35 AM, Stefan Hajnoczi wrote: > > > Commit dd577a26ff03b6829721b1ffbbf9e7c411b72378 ("block/file-posix: > > > implement bdrv_co_invalidate_cache() on Linux

Re: [Qemu-devel] [PATCH] file-posix: add drop-cache=on|off option

2019-02-27 Thread Stefan Hajnoczi
On Tue, Feb 26, 2019 at 10:54:55AM -0600, Eric Blake wrote: > On 2/26/19 9:35 AM, Stefan Hajnoczi wrote: > > Commit dd577a26ff03b6829721b1ffbbf9e7c411b72378 ("block/file-posix: > > implement bdrv_co_invalidate_cache() on Linux") introduced page cache > > invalidation so that cache.direct=off live m

Re: [Qemu-devel] [PATCH] file-posix: add drop-cache=on|off option

2019-02-27 Thread Stefano Garzarella
On Tue, Feb 26, 2019 at 03:35:49PM +, Stefan Hajnoczi wrote: > Commit dd577a26ff03b6829721b1ffbbf9e7c411b72378 ("block/file-posix: > implement bdrv_co_invalidate_cache() on Linux") introduced page cache > invalidation so that cache.direct=off live migration is safe on Linux. > > The invalidati

Re: [Qemu-devel] [PATCH] file-posix: add drop-cache=on|off option

2019-02-26 Thread Neil Skrypuch
On Tuesday, February 26, 2019 10:35:49 AM EST Stefan Hajnoczi wrote: > Suggested-by: Neil Skrypuch > Signed-off-by: Stefan Hajnoczi > --- > qapi/block-core.json | 5 + > block/file-posix.c | 14 ++ > 2 files changed, 19 insertions(+) Tested-by: Neil Skrypuch Applied this pa

Re: [Qemu-devel] [PATCH] file-posix: add drop-cache=on|off option

2019-02-26 Thread Eric Blake
On 2/26/19 9:35 AM, Stefan Hajnoczi wrote: > Commit dd577a26ff03b6829721b1ffbbf9e7c411b72378 ("block/file-posix: > implement bdrv_co_invalidate_cache() on Linux") introduced page cache > invalidation so that cache.direct=off live migration is safe on Linux. > > The invalidation takes a significant

[Qemu-devel] [PATCH] file-posix: add drop-cache=on|off option

2019-02-26 Thread Stefan Hajnoczi
Commit dd577a26ff03b6829721b1ffbbf9e7c411b72378 ("block/file-posix: implement bdrv_co_invalidate_cache() on Linux") introduced page cache invalidation so that cache.direct=off live migration is safe on Linux. The invalidation takes a significant amount of time when the file is large and present in