At 04/12/2011 05:20 PM, Isaku Yamahata Write:
> On Tue, Apr 12, 2011 at 05:08:18PM +0800, Wen Congyang wrote:
>> At 04/12/2011 04:48 PM, Isaku Yamahata Write:
>>> On Tue, Apr 12, 2011 at 01:13:15PM +0800, Wen Congyang wrote:
This bug is introduced by commit 23910d3f.
>>>
>>> Oh, Thanks. Good c
On Tue, Apr 12, 2011 at 05:08:18PM +0800, Wen Congyang wrote:
> At 04/12/2011 04:48 PM, Isaku Yamahata Write:
> > On Tue, Apr 12, 2011 at 01:13:15PM +0800, Wen Congyang wrote:
> >> This bug is introduced by commit 23910d3f.
> >
> > Oh, Thanks. Good catch. I agree with the first hunk.
> > But what
At 04/12/2011 04:48 PM, Isaku Yamahata Write:
> On Tue, Apr 12, 2011 at 01:13:15PM +0800, Wen Congyang wrote:
>> This bug is introduced by commit 23910d3f.
>
> Oh, Thanks. Good catch. I agree with the first hunk.
> But what is the second hunk for? The GPE STS register is W1C.
> (NULL check and 0xf
On Tue, Apr 12, 2011 at 01:13:15PM +0800, Wen Congyang wrote:
> This bug is introduced by commit 23910d3f.
Oh, Thanks. Good catch. I agree with the first hunk.
But what is the second hunk for? The GPE STS register is W1C.
(NULL check and 0xff masking is okay. it's a bit redundant, though)
>From A
This bug is introduced by commit 23910d3f.
Signed-off-by: Wen Congyang
---
hw/acpi.c | 10 +++---
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/hw/acpi.c b/hw/acpi.c
index e372474..790bd3b 100644
--- a/hw/acpi.c
+++ b/hw/acpi.c
@@ -355,7 +355,7 @@ static uint8_t *acpi_gpe
