Re: [Qemu-devel] [PATCH] fix bits 39:32 of the final physical address when using 4M page

2013-01-09 Thread Luiz Capitulino
On Sat, 22 Dec 2012 15:13:54 +0800 Wen Congyang wrote: > ((pde & 0x1fe000) << 19) is the bits 39:32 of the final physical address, and > we shouldn't use unit32_t to calculate it. Convert the type to hwaddr to fix > this problem. > > Signed-off-by: Wen Congyang Applied to the qmp branch, thank

Re: [Qemu-devel] [PATCH] fix bits 39:32 of the final physical address when using 4M page

2013-01-07 Thread Luiz Capitulino
On Mon, 07 Jan 2013 14:10:46 +0100 Andreas Färber wrote: > Am 07.01.2013 13:06, schrieb Markus Armbruster: > > Wen Congyang writes: > > > >> ((pde & 0x1fe000) << 19) is the bits 39:32 of the final physical address, > >> and > >> we shouldn't use unit32_t to calculate it. Convert the type to hw

Re: [Qemu-devel] [PATCH] fix bits 39:32 of the final physical address when using 4M page

2013-01-07 Thread Andreas Färber
Am 07.01.2013 13:06, schrieb Markus Armbruster: > Wen Congyang writes: > >> ((pde & 0x1fe000) << 19) is the bits 39:32 of the final physical address, and >> we shouldn't use unit32_t to calculate it. Convert the type to hwaddr to fix >> this problem. > > Spotted by Coverity. > >> Signed-off-by:

Re: [Qemu-devel] [PATCH] fix bits 39:32 of the final physical address when using 4M page

2013-01-07 Thread Markus Armbruster
Wen Congyang writes: > ((pde & 0x1fe000) << 19) is the bits 39:32 of the final physical address, and > we shouldn't use unit32_t to calculate it. Convert the type to hwaddr to fix > this problem. Spotted by Coverity. > Signed-off-by: Wen Congyang > > --- > target-i386/arch_memory_mapping.c |

[Qemu-devel] [PATCH] fix bits 39:32 of the final physical address when using 4M page

2012-12-22 Thread Wen Congyang
((pde & 0x1fe000) << 19) is the bits 39:32 of the final physical address, and we shouldn't use unit32_t to calculate it. Convert the type to hwaddr to fix this problem. Signed-off-by: Wen Congyang --- target-i386/arch_memory_mapping.c | 11 --- 1 file changed, 8 insertions(+), 3 deletio