Re: [Qemu-devel] [PATCH] fpu_helper.c: fix helper_fpscr_clrbit() function

2018-06-18 Thread Programmingkid
> On Jun 18, 2018, at 7:30 AM, Peter Maydell wrote: > > On 17 June 2018 at 16:53, John Arbuckle wrote: >> Fix the helper_fpscr_clrbit() function so it correctly >> sets the FEX and VX bits. >> >> Signed-off-by: John Arbuckle >> --- >> target/ppc/fpu_helper.c | 57 >>

Re: [Qemu-devel] [PATCH] fpu_helper.c: fix helper_fpscr_clrbit() function

2018-06-18 Thread Peter Maydell
On 17 June 2018 at 16:53, John Arbuckle wrote: > Fix the helper_fpscr_clrbit() function so it correctly > sets the FEX and VX bits. > > Signed-off-by: John Arbuckle > --- > target/ppc/fpu_helper.c | 57 > + > 1 file changed, 57 insertions(+) > > d

Re: [Qemu-devel] [PATCH] fpu_helper.c: fix helper_fpscr_clrbit() function

2018-06-17 Thread Programmingkid
> On Jun 17, 2018, at 8:34 PM, David Gibson wrote: > > On Sun, Jun 17, 2018 at 11:53:09AM -0400, John Arbuckle wrote: >> Fix the helper_fpscr_clrbit() function so it correctly >> sets the FEX and VX bits. > > This needs a lot more information in the commit message: > > * What exactly was wro

Re: [Qemu-devel] [PATCH] fpu_helper.c: fix helper_fpscr_clrbit() function

2018-06-17 Thread David Gibson
On Sun, Jun 17, 2018 at 11:53:09AM -0400, John Arbuckle wrote: > Fix the helper_fpscr_clrbit() function so it correctly > sets the FEX and VX bits. This needs a lot more information in the commit message: * What exactly was wrong with the previous setting of the FEX and VX bits? * Where

[Qemu-devel] [PATCH] fpu_helper.c: fix helper_fpscr_clrbit() function

2018-06-17 Thread John Arbuckle
Fix the helper_fpscr_clrbit() function so it correctly sets the FEX and VX bits. Signed-off-by: John Arbuckle --- target/ppc/fpu_helper.c | 57 + 1 file changed, 57 insertions(+) diff --git a/target/ppc/fpu_helper.c b/target/ppc/fpu_helper.c index