Re: [Qemu-devel] [PATCH] fw_cfg_reboot: ensure reboot_time is nonegative

2018-11-01 Thread Li Qiang
Thanks Eric and Markus's review, I have sent out another patch. I'm not sure what's the effect when the etc/reboot-timeout and etc/splash-time is 0 in seabios, so CC'd Gerd. Maybe it can be more simplicity. Thanks, Li Qiang Eric Blake 于2018年10月31日周三 下午11:55写道: > On 10/24/18 6:35 AM, Laszlo

Re: [Qemu-devel] [PATCH] fw_cfg_reboot: ensure reboot_time is nonegative

2018-10-31 Thread Eric Blake
On 10/24/18 6:35 AM, Laszlo Ersek wrote: On 10/24/18 09:11, Li Qiang wrote: This can avoid setting a negative value to etc/boot-fail-wait. Signed-off-by: Li Qiang --- hw/nvram/fw_cfg.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/nvram/fw_cfg.c

Re: [Qemu-devel] [PATCH] fw_cfg_reboot: ensure reboot_time is nonegative

2018-10-31 Thread Markus Armbruster
Laszlo Ersek writes: > On 10/24/18 09:11, Li Qiang wrote: >> This can avoid setting a negative value to >> etc/boot-fail-wait. >> >> Signed-off-by: Li Qiang >> --- >> hw/nvram/fw_cfg.c | 15 ++- >> 1 file changed, 10 insertions(+), 5 deletions(-) >> >> diff --git

Re: [Qemu-devel] [PATCH] fw_cfg_reboot: ensure reboot_time is nonegative

2018-10-29 Thread Li Qiang
Philippe Mathieu-Daudé 于2018年10月30日周二 上午7:50写道: > On 25/10/18 3:45, Li Qiang wrote: > > Hello Laszlo and Philippe , > > > > Thanks for your review, > > > > > > > > Philippe Mathieu-Daudé mailto:phi...@redhat.com>> 于 > > 2018年10月25日周四 上午6:56写道: > > > > Hi, > > > > On 24/10/18 13:35,

Re: [Qemu-devel] [PATCH] fw_cfg_reboot: ensure reboot_time is nonegative

2018-10-29 Thread Philippe Mathieu-Daudé
On 25/10/18 3:45, Li Qiang wrote: Hello Laszlo and Philippe , Thanks for your review, Philippe Mathieu-Daudé mailto:phi...@redhat.com>> 于 2018年10月25日周四 上午6:56写道: Hi, On 24/10/18 13:35, Laszlo Ersek wrote: > On 10/24/18 09:11, Li Qiang wrote: >> This can avoid setting a

Re: [Qemu-devel] [PATCH] fw_cfg_reboot: ensure reboot_time is nonegative

2018-10-24 Thread Li Qiang
Hello Laszlo and Philippe , Thanks for your review, Philippe Mathieu-Daudé 于2018年10月25日周四 上午6:56写道: > Hi, > > On 24/10/18 13:35, Laszlo Ersek wrote: > > On 10/24/18 09:11, Li Qiang wrote: > >> This can avoid setting a negative value to > >> etc/boot-fail-wait. > > Li Qiang, can you add a

Re: [Qemu-devel] [PATCH] fw_cfg_reboot: ensure reboot_time is nonegative

2018-10-24 Thread Philippe Mathieu-Daudé
Hi, On 24/10/18 13:35, Laszlo Ersek wrote: On 10/24/18 09:11, Li Qiang wrote: This can avoid setting a negative value to etc/boot-fail-wait. Li Qiang, can you add a qtest for this? Signed-off-by: Li Qiang --- hw/nvram/fw_cfg.c | 15 ++- 1 file changed, 10 insertions(+), 5

Re: [Qemu-devel] [PATCH] fw_cfg_reboot: ensure reboot_time is nonegative

2018-10-24 Thread Laszlo Ersek
On 10/24/18 09:11, Li Qiang wrote: > This can avoid setting a negative value to > etc/boot-fail-wait. > > Signed-off-by: Li Qiang > --- > hw/nvram/fw_cfg.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c > index

[Qemu-devel] [PATCH] fw_cfg_reboot: ensure reboot_time is nonegative

2018-10-24 Thread Li Qiang
This can avoid setting a negative value to etc/boot-fail-wait. Signed-off-by: Li Qiang --- hw/nvram/fw_cfg.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index f4a52d8..276dcb1 100644 --- a/hw/nvram/fw_cfg.c +++