Re: [Qemu-devel] [PATCH] gdbstub: Prevent fd leakage

2018-05-25 Thread Peter Maydell
On 24 May 2018 at 23:34, Philippe Mathieu-Daudé wrote: > Since 2f652224f7, we now check if socket_set_nodelay() errored, > but forgot to close the socket before reporting an error. > > Fixes: Coverity CID 1391290 (RESOURCE_LEAK) > Signed-off-by: Philippe Mathieu-Daudé > --- > gdbstub.c | 1 + >

Re: [Qemu-devel] [PATCH] gdbstub: Prevent fd leakage

2018-05-24 Thread Thomas Huth
On 25.05.2018 00:34, Philippe Mathieu-Daudé wrote: > Since 2f652224f7, we now check if socket_set_nodelay() errored, > but forgot to close the socket before reporting an error. > > Fixes: Coverity CID 1391290 (RESOURCE_LEAK) > Signed-off-by: Philippe Mathieu-Daudé > --- > gdbstub.c | 1 + > 1 fi

[Qemu-devel] [PATCH] gdbstub: Prevent fd leakage

2018-05-24 Thread Philippe Mathieu-Daudé
Since 2f652224f7, we now check if socket_set_nodelay() errored, but forgot to close the socket before reporting an error. Fixes: Coverity CID 1391290 (RESOURCE_LEAK) Signed-off-by: Philippe Mathieu-Daudé --- gdbstub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdbstub.c b/gdbstub.c inde