Re: [Qemu-devel] [PATCH] get_tmp_filename: add explicit error message

2013-02-04 Thread Stefan Hajnoczi
On Fri, Feb 01, 2013 at 06:13:51PM +0100, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteau chout...@adacore.com --- block.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) Hi Fabien, Please always CC qemu-devel@nongnu.org. All patches must be on qemu-devel so

Re: [Qemu-devel] [PATCH] get_tmp_filename: add explicit error message

2013-02-04 Thread Markus Armbruster
Stefan Hajnoczi stefa...@redhat.com writes: On Fri, Feb 01, 2013 at 06:13:51PM +0100, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteau chout...@adacore.com --- block.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) Hi Fabien, Please always CC

Re: [Qemu-devel] [PATCH] get_tmp_filename: add explicit error message

2013-02-04 Thread Fabien Chouteau
On 02/04/2013 11:34 AM, Markus Armbruster wrote: Stefan Hajnoczi stefa...@redhat.com writes: On Fri, Feb 01, 2013 at 06:13:51PM +0100, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteau chout...@adacore.com --- block.c | 13 ++--- 1 file changed, 10 insertions(+), 3

Re: [Qemu-devel] [PATCH] get_tmp_filename: add explicit error message

2013-02-04 Thread Markus Armbruster
Fabien Chouteau chout...@adacore.com writes: On 02/04/2013 11:34 AM, Markus Armbruster wrote: Stefan Hajnoczi stefa...@redhat.com writes: On Fri, Feb 01, 2013 at 06:13:51PM +0100, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteau chout...@adacore.com --- block.c | 13 ++---

Re: [Qemu-devel] [PATCH] get_tmp_filename: add explicit error message

2013-02-04 Thread Fabien Chouteau
On 02/04/2013 01:24 PM, Markus Armbruster wrote: Fabien Chouteau chout...@adacore.com writes: On 02/04/2013 11:34 AM, Markus Armbruster wrote: Why? The caller doesn't know the difference between Windows/Linux implementation. And the error handling would have to be duplicated. The

Re: [Qemu-devel] [PATCH] get_tmp_filename: add explicit error message

2013-02-04 Thread Andreas Färber
Am 04.02.2013 14:33, schrieb Fabien Chouteau: On 02/04/2013 01:24 PM, Markus Armbruster wrote: Good error reporting is hard. Knowledge about the error and its context gets lost as you move up the call chain. Knowledge about how to report errors gets lost as you move down. You're right,