On 05/09/14 13:39, Stefan Hajnoczi wrote:
> On Fri, May 09, 2014 at 12:08:10PM +0200, Peter Krempa wrote:
...
>
> Please use scripts/checkpatch.pl to check coding style in the future. I
> added {} around the if statement body. QEMU always uses curlies even
> for 1-statement bodies.
Ah, right,
On Fri, May 09, 2014 at 12:08:10PM +0200, Peter Krempa wrote:
> The docs for glfs_init suggest that the function sets errno on every
> failure. In fact it doesn't. As other functions such as
> qemu_gluster_open() in the gluster block code report their errors based
> on this fact we need to make sur
The docs for glfs_init suggest that the function sets errno on every
failure. In fact it doesn't. As other functions such as
qemu_gluster_open() in the gluster block code report their errors based
on this fact we need to make sure that errno is set on each failure.
This fixes a crash of qemu-img/q