Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-28 Thread Igor Mammedov
On Fri, 28 Nov 2014 07:53:41 +0200 Marcel Apfelbaum marce...@redhat.com wrote: On Fri, 2014-11-28 at 09:50 +0800, Zhu Guihua wrote: On Thu, 2014-11-27 at 15:48 +0200, Marcel Apfelbaum wrote: On Thu, 2014-11-27 at 13:38 +0100, Igor Mammedov wrote: On Thu, 27 Nov 2014 13:41:07 +0200

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-27 Thread Marcel Apfelbaum
On Wed, 2014-11-26 at 13:05 -0500, Luiz Capitulino wrote: On Wed, 26 Nov 2014 13:50:01 +0200 Marcel Apfelbaum marce...@redhat.com wrote: The commits: - 6a1fa9f5 (monitor: add del completion for peripheral device) - 66e56b13 (qdev: add qdev_build_hotpluggable_device_list helper)

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-27 Thread Marcel Apfelbaum
On Thu, 2014-11-27 at 13:11 +0200, Marcel Apfelbaum wrote: On Wed, 2014-11-26 at 13:05 -0500, Luiz Capitulino wrote: On Wed, 26 Nov 2014 13:50:01 +0200 Marcel Apfelbaum marce...@redhat.com wrote: The commits: - 6a1fa9f5 (monitor: add del completion for peripheral device) -

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-27 Thread Zhu Guihua
On Thu, 2014-11-27 at 13:11 +0200, Marcel Apfelbaum wrote: On Wed, 2014-11-26 at 13:05 -0500, Luiz Capitulino wrote: On Wed, 26 Nov 2014 13:50:01 +0200 Marcel Apfelbaum marce...@redhat.com wrote: The commits: - 6a1fa9f5 (monitor: add del completion for peripheral device) -

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-27 Thread Marcel Apfelbaum
On Thu, 2014-11-27 at 19:35 +0800, Zhu Guihua wrote: On Thu, 2014-11-27 at 13:11 +0200, Marcel Apfelbaum wrote: On Wed, 2014-11-26 at 13:05 -0500, Luiz Capitulino wrote: On Wed, 26 Nov 2014 13:50:01 +0200 Marcel Apfelbaum marce...@redhat.com wrote: The commits: - 6a1fa9f5

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-27 Thread Zhu Guihua
On Thu, 2014-11-27 at 13:41 +0200, Marcel Apfelbaum wrote: On Thu, 2014-11-27 at 19:35 +0800, Zhu Guihua wrote: On Thu, 2014-11-27 at 13:11 +0200, Marcel Apfelbaum wrote: On Wed, 2014-11-26 at 13:05 -0500, Luiz Capitulino wrote: On Wed, 26 Nov 2014 13:50:01 +0200 Marcel Apfelbaum

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-27 Thread Marcel Apfelbaum
On Thu, 2014-11-27 at 20:08 +0800, Zhu Guihua wrote: On Thu, 2014-11-27 at 13:41 +0200, Marcel Apfelbaum wrote: On Thu, 2014-11-27 at 19:35 +0800, Zhu Guihua wrote: On Thu, 2014-11-27 at 13:11 +0200, Marcel Apfelbaum wrote: On Wed, 2014-11-26 at 13:05 -0500, Luiz Capitulino wrote:

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-27 Thread Igor Mammedov
On Thu, 27 Nov 2014 13:41:07 +0200 Marcel Apfelbaum marce...@redhat.com wrote: On Thu, 2014-11-27 at 19:35 +0800, Zhu Guihua wrote: On Thu, 2014-11-27 at 13:11 +0200, Marcel Apfelbaum wrote: On Wed, 2014-11-26 at 13:05 -0500, Luiz Capitulino wrote: On Wed, 26 Nov 2014 13:50:01 +0200

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-27 Thread Marcel Apfelbaum
On Thu, 2014-11-27 at 13:38 +0100, Igor Mammedov wrote: On Thu, 27 Nov 2014 13:41:07 +0200 Marcel Apfelbaum marce...@redhat.com wrote: On Thu, 2014-11-27 at 19:35 +0800, Zhu Guihua wrote: On Thu, 2014-11-27 at 13:11 +0200, Marcel Apfelbaum wrote: On Wed, 2014-11-26 at 13:05 -0500,

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-27 Thread Peter Maydell
On 27 November 2014 at 11:41, Marcel Apfelbaum marce...@redhat.com wrote: I was talking about something different: A hot-pluggable device that was not hot-plugged is assumed to be hot-unpluggable. This is not true for pci-2-pci device. But this is another issue and can wait for 2.3. So you

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-27 Thread Luiz Capitulino
On Thu, 27 Nov 2014 13:41:07 +0200 Marcel Apfelbaum marce...@redhat.com wrote: On Thu, 2014-11-27 at 19:35 +0800, Zhu Guihua wrote: On Thu, 2014-11-27 at 13:11 +0200, Marcel Apfelbaum wrote: On Wed, 2014-11-26 at 13:05 -0500, Luiz Capitulino wrote: On Wed, 26 Nov 2014 13:50:01 +0200

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-27 Thread Marcel Apfelbaum
On Thu, 2014-11-27 at 14:13 +, Peter Maydell wrote: On 27 November 2014 at 11:41, Marcel Apfelbaum marce...@redhat.com wrote: I was talking about something different: A hot-pluggable device that was not hot-plugged is assumed to be hot-unpluggable. This is not true for pci-2-pci

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-27 Thread Peter Maydell
On 26 November 2014 at 11:50, Marcel Apfelbaum marce...@redhat.com wrote: The commits: - 6a1fa9f5 (monitor: add del completion for peripheral device) - 66e56b13 (qdev: add qdev_build_hotpluggable_device_list helper) cause a QEMU crash when trying to use HMP device_del auto-completion. It

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-27 Thread Zhu Guihua
On Thu, 2014-11-27 at 14:15 +0200, Marcel Apfelbaum wrote: On Thu, 2014-11-27 at 20:08 +0800, Zhu Guihua wrote: On Thu, 2014-11-27 at 13:41 +0200, Marcel Apfelbaum wrote: On Thu, 2014-11-27 at 19:35 +0800, Zhu Guihua wrote: On Thu, 2014-11-27 at 13:11 +0200, Marcel Apfelbaum wrote:

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-27 Thread Zhu Guihua
On Thu, 2014-11-27 at 15:48 +0200, Marcel Apfelbaum wrote: On Thu, 2014-11-27 at 13:38 +0100, Igor Mammedov wrote: On Thu, 27 Nov 2014 13:41:07 +0200 Marcel Apfelbaum marce...@redhat.com wrote: On Thu, 2014-11-27 at 19:35 +0800, Zhu Guihua wrote: On Thu, 2014-11-27 at 13:11 +0200,

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-27 Thread Marcel Apfelbaum
On Fri, 2014-11-28 at 09:50 +0800, Zhu Guihua wrote: On Thu, 2014-11-27 at 15:48 +0200, Marcel Apfelbaum wrote: On Thu, 2014-11-27 at 13:38 +0100, Igor Mammedov wrote: On Thu, 27 Nov 2014 13:41:07 +0200 Marcel Apfelbaum marce...@redhat.com wrote: On Thu, 2014-11-27 at 19:35 +0800,

[Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-26 Thread Marcel Apfelbaum
The commits: - 6a1fa9f5 (monitor: add del completion for peripheral device) - 66e56b13 (qdev: add qdev_build_hotpluggable_device_list helper) cause a QEMU crash when trying to use HMP device_del auto-completion. It can be easily reproduced by: qemu-bin -enable-kvm ~/images/fedora.qcow2

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-26 Thread Igor Mammedov
On Wed, 26 Nov 2014 13:50:01 +0200 Marcel Apfelbaum marce...@redhat.com wrote: The commits: - 6a1fa9f5 (monitor: add del completion for peripheral device) - 66e56b13 (qdev: add qdev_build_hotpluggable_device_list helper) cause a QEMU crash when trying to use HMP device_del

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-26 Thread Luiz Capitulino
On Wed, 26 Nov 2014 13:50:01 +0200 Marcel Apfelbaum marce...@redhat.com wrote: The commits: - 6a1fa9f5 (monitor: add del completion for peripheral device) - 66e56b13 (qdev: add qdev_build_hotpluggable_device_list helper) cause a QEMU crash when trying to use HMP device_del

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-26 Thread Peter Maydell
On 26 November 2014 at 18:05, Luiz Capitulino lcapitul...@redhat.com wrote: Peter, can you apply this patch directly to master to avoid me a pull request? Maybe it's a good idea to wait until tomorrow for more reviewers though. Sure. I'll apply it to master some time tomorrow afternoon I

Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

2014-11-26 Thread Marcel Apfelbaum
On Wed, 2014-11-26 at 13:05 -0500, Luiz Capitulino wrote: On Wed, 26 Nov 2014 13:50:01 +0200 Marcel Apfelbaum marce...@redhat.com wrote: The commits: - 6a1fa9f5 (monitor: add del completion for peripheral device) - 66e56b13 (qdev: add qdev_build_hotpluggable_device_list helper)