Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-17 Thread Aneesh Kumar K.V
Greg Kurz writes: > On Tue, 15 Mar 2016 00:02:48 +0800 > Jevon Qiao wrote: > >> Ceph as a promising unified distributed storage system is widely used in the >> world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and >> object (S3/Swift) are unsurprisingly looking at Manila and

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-15 Thread Greg Kurz
One more nit in configure. See below. Cheers. -- Greg On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: > Ceph as a promising unified distributed storage system is widely used in the > world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and > object (S3/Swift) are unsurpri

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-15 Thread Greg Kurz
Hi Jevon, More findings in fsdev/qemu-fsdev.c and hw/9pfs/Makefile.objs, see below. Cheers. -- Greg On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: > Ceph as a promising unified distributed storage system is widely used in the > world of OpenStack. OpenStack users deploying Ceph for blo

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-13 Thread Greg Kurz
Hi Jevon, On Sun, 10 Apr 2016 14:55:55 +0800 Jevon Qiao wrote: > Hi Greg, > > Thank you for spending time reviewing this patch. > On 7/4/16 23:50, Greg Kurz wrote: > > On Tue, 15 Mar 2016 00:02:48 +0800 > > Jevon Qiao wrote: > > > >> Ceph as a promising unified distributed storage system is

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-09 Thread Jevon Qiao
Hi Greg, Thank you for spending time reviewing this patch. On 7/4/16 23:50, Greg Kurz wrote: On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: Ceph as a promising unified distributed storage system is widely used in the world of OpenStack. OpenStack users deploying Ceph for block (Cinder)

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-07 Thread Greg Kurz
On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: > Ceph as a promising unified distributed storage system is widely used in the > world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and > object (S3/Swift) are unsurprisingly looking at Manila and CephFS to round out > a unif

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-05 Thread Jevon Qiao
On 5/4/16 23:31, Greg Kurz wrote: On Tue, 5 Apr 2016 23:27:33 +0800 Jevon Qiao wrote: Hi Greg, Any further comment? Thanks, Jevon Hi Jevon, Yes ! I could at last resume the review of your patch today. You can expect an answer this week. Ok, thanks. /Jevon Cheers. -- Greg On 15/3/16 22

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-05 Thread Greg Kurz
On Tue, 5 Apr 2016 23:27:33 +0800 Jevon Qiao wrote: > Hi Greg, > > Any further comment? > > Thanks, > Jevon Hi Jevon, Yes ! I could at last resume the review of your patch today. You can expect an answer this week. Cheers. -- Greg > On 15/3/16 22:16, Jevon Qiao wrote: > > On 15/3/16 21:46,

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-05 Thread Jevon Qiao
Hi Greg, Any further comment? Thanks, Jevon On 15/3/16 22:16, Jevon Qiao wrote: On 15/3/16 21:46, Greg Kurz wrote: On Tue, 15 Mar 2016 21:39:45 +0800 Jevon Qiao wrote: On 15/3/16 17:30, Greg Kurz wrote: On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: Ceph as a promising unified distr

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-15 Thread Jevon Qiao
Hi Michael, Thank you for the comment below. On 15/3/16 21:52, Michael S. Tsirkin wrote: On Tue, Mar 15, 2016 at 12:02:48AM +0800, Jevon Qiao wrote: diff --git a/hw/9pfs/9p-cephfs.c b/hw/9pfs/9p-cephfs.c new file mode 100644 index 000..e2d659d --- /dev/null +++ b/hw/9pfs/9p-cephfs.c @@ -0,0

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-15 Thread Jevon Qiao
On 15/3/16 21:46, Greg Kurz wrote: On Tue, 15 Mar 2016 21:39:45 +0800 Jevon Qiao wrote: On 15/3/16 17:30, Greg Kurz wrote: On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: Ceph as a promising unified distributed storage system is widely used in the world of OpenStack. OpenStack users

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-15 Thread Michael S. Tsirkin
On Tue, Mar 15, 2016 at 12:02:48AM +0800, Jevon Qiao wrote: > diff --git a/hw/9pfs/9p-cephfs.c b/hw/9pfs/9p-cephfs.c > new file mode 100644 > index 000..e2d659d > --- /dev/null > +++ b/hw/9pfs/9p-cephfs.c > @@ -0,0 +1,836 @@ > +/* > + * 9p cephfs callback > + * > + * Copyright UnitedStack, Corp

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-15 Thread Greg Kurz
On Tue, 15 Mar 2016 21:39:45 +0800 Jevon Qiao wrote: > On 15/3/16 17:30, Greg Kurz wrote: > > On Tue, 15 Mar 2016 00:02:48 +0800 > > Jevon Qiao wrote: > > > >> Ceph as a promising unified distributed storage system is widely used in > >> the > >> world of OpenStack. OpenStack users deploying

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-15 Thread Jevon Qiao
On 15/3/16 17:30, Greg Kurz wrote: On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: Ceph as a promising unified distributed storage system is widely used in the world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and object (S3/Swift) are unsurprisingly looking at Manila

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-15 Thread Greg Kurz
On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: > Ceph as a promising unified distributed storage system is widely used in the > world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and > object (S3/Swift) are unsurprisingly looking at Manila and CephFS to round out > a unif

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-13 Thread Jevon Qiao
Hi Greg, Thank you very much for reviewing the code, I've revised the code per your comments, will post it later. Meanwhile, please see my answers to your questions below. +} +fs->dir = (DIR *)result; +if (!fs->dir) { +fprintf(stderr, "ceph_opendir return NULL for ceph_di

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-10 Thread Greg Kurz
On Wed, 9 Mar 2016 13:09:58 -0700 Eric Blake wrote: > On 03/09/2016 12:02 PM, Greg Kurz wrote: > > On Wed, 2 Mar 2016 23:41:43 +0800 > > Jevon Qiao wrote: > > > > >> +} > >> + > >> +static int cephfs_readdir_r(FsContext *ctx, V9fsFidOpenState *fs, > >> +struct di

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-09 Thread Eric Blake
On 03/09/2016 12:02 PM, Greg Kurz wrote: > On Wed, 2 Mar 2016 23:41:43 +0800 > Jevon Qiao wrote: > >> +} >> + >> +static int cephfs_readdir_r(FsContext *ctx, V9fsFidOpenState *fs, >> +struct dirent *entry, >> +struct dirent **result) >> +{

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-09 Thread Greg Kurz
On Wed, 2 Mar 2016 23:41:43 +0800 Jevon Qiao wrote: > Ceph as a promising unified distributed storage system is widely used in the > world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and > object (S3/Swift) are unsurprisingly looking at Manila and CephFS to round out > a unif

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-09 Thread Greg Kurz
On Tue, 8 Mar 2016 08:51:23 +0800 Jevon Qiao wrote: > Any further comment on this patch? > First comment is: $ git show | ./scripts/checkpatch.pl - | grep ^total total: 44 errors, 7 warnings, 975 lines checked I'm now reading the patch and will come back with other comments. > Thanks, > Jevo

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-07 Thread Jevon Qiao
Any further comment on this patch? Thanks, Jevon On 2/3/16 23:41, Jevon Qiao wrote: Ceph as a promising unified distributed storage system is widely used in the world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and object (S3/Swift) are unsurprisingly looking at Manila and Ce

[Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-02 Thread Jevon Qiao
Ceph as a promising unified distributed storage system is widely used in the world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and object (S3/Swift) are unsurprisingly looking at Manila and CephFS to round out a unified storage solution. Since the typical hypervisor people are u