Re: [Qemu-devel] [PATCH] hw/arm/virt: gicv3: use all target-list bits

2016-06-27 Thread Andrew Jones
On Mon, Jun 27, 2016 at 08:51:43AM +0100, Marc Zyngier wrote: > On 27/06/16 07:41, Andrew Jones wrote: > > On Fri, Jun 24, 2016 at 06:27:20PM +0100, Peter Maydell wrote: > >> On 24 June 2016 at 18:22, Andrew Jones wrote: > >>> On Fri, Jun 24, 2016 at 05:41:55PM +0100, Peter Maydell wrote: > K

Re: [Qemu-devel] [PATCH] hw/arm/virt: gicv3: use all target-list bits

2016-06-27 Thread Marc Zyngier
On 27/06/16 07:41, Andrew Jones wrote: > On Fri, Jun 24, 2016 at 06:27:20PM +0100, Peter Maydell wrote: >> On 24 June 2016 at 18:22, Andrew Jones wrote: >>> On Fri, Jun 24, 2016 at 05:41:55PM +0100, Peter Maydell wrote: KVM AArch32 is 4 CPUs per cluster: http://lxr.free-electrons.com/sou

Re: [Qemu-devel] [PATCH] hw/arm/virt: gicv3: use all target-list bits

2016-06-26 Thread Andrew Jones
On Fri, Jun 24, 2016 at 06:27:20PM +0100, Peter Maydell wrote: > On 24 June 2016 at 18:22, Andrew Jones wrote: > > On Fri, Jun 24, 2016 at 05:41:55PM +0100, Peter Maydell wrote: > >> KVM AArch32 is 4 CPUs per cluster: > >> http://lxr.free-electrons.com/source/arch/arm/kvm/coproc.c#L109 > > > > Hmm

Re: [Qemu-devel] [PATCH] hw/arm/virt: gicv3: use all target-list bits

2016-06-24 Thread Peter Maydell
On 24 June 2016 at 18:22, Andrew Jones wrote: > On Fri, Jun 24, 2016 at 05:41:55PM +0100, Peter Maydell wrote: >> KVM AArch32 is 4 CPUs per cluster: >> http://lxr.free-electrons.com/source/arch/arm/kvm/coproc.c#L109 > > Hmm... yes, it should use coproc.c, but here's what I get when I > test > > qe

Re: [Qemu-devel] [PATCH] hw/arm/virt: gicv3: use all target-list bits

2016-06-24 Thread Andrew Jones
On Fri, Jun 24, 2016 at 05:41:55PM +0100, Peter Maydell wrote: > On 24 June 2016 at 17:15, Andrew Jones wrote: > > On Fri, Jun 24, 2016 at 06:03:21PM +0200, Andrew Jones wrote: > >> So we can either > >> a) play it safe and always use clusters of 4 for ARM guests, and > >>KVM will get "fixed"

Re: [Qemu-devel] [PATCH] hw/arm/virt: gicv3: use all target-list bits

2016-06-24 Thread Peter Maydell
On 24 June 2016 at 17:15, Andrew Jones wrote: > On Fri, Jun 24, 2016 at 06:03:21PM +0200, Andrew Jones wrote: >> So we can either >> a) play it safe and always use clusters of 4 for ARM guests, and >>KVM will get "fixed" when we start managing the guest's MPIDR >>from userspace, or >> b) u

Re: [Qemu-devel] [PATCH] hw/arm/virt: gicv3: use all target-list bits

2016-06-24 Thread Andrew Jones
On Thu, Jun 23, 2016 at 12:15:59PM +0100, Peter Maydell wrote: > On 21 June 2016 at 19:58, Andrew Jones wrote: > > Signed-off-by: Andrew Jones > > I think this commit message could be improved...it's both > very short and a bit off the mark. > > > --- > > hw/arm/virt.c | 10 ++ > > 1 f

Re: [Qemu-devel] [PATCH] hw/arm/virt: gicv3: use all target-list bits

2016-06-24 Thread Andrew Jones
On Fri, Jun 24, 2016 at 06:03:21PM +0200, Andrew Jones wrote: > On Thu, Jun 23, 2016 at 12:15:59PM +0100, Peter Maydell wrote: > > On 21 June 2016 at 19:58, Andrew Jones wrote: > > > Signed-off-by: Andrew Jones > > > > I think this commit message could be improved...it's both > > very short and

Re: [Qemu-devel] [PATCH] hw/arm/virt: gicv3: use all target-list bits

2016-06-23 Thread Andrew Jones
On Thu, Jun 23, 2016 at 12:15:59PM +0100, Peter Maydell wrote: > On 21 June 2016 at 19:58, Andrew Jones wrote: > > Signed-off-by: Andrew Jones > > I think this commit message could be improved...it's both > very short and a bit off the mark. > > > --- > > hw/arm/virt.c | 10 ++ > > 1 f

Re: [Qemu-devel] [PATCH] hw/arm/virt: gicv3: use all target-list bits

2016-06-23 Thread Peter Maydell
On 21 June 2016 at 19:58, Andrew Jones wrote: > Signed-off-by: Andrew Jones I think this commit message could be improved...it's both very short and a bit off the mark. > --- > hw/arm/virt.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > in

[Qemu-devel] [PATCH] hw/arm/virt: gicv3: use all target-list bits

2016-06-21 Thread Andrew Jones
Signed-off-by: Andrew Jones --- hw/arm/virt.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index c5c125e9204a0..53f545921003c 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -1271,6 +1271,16 @@ static void machvirt_init(MachineState *machine)