Re: [Qemu-devel] [PATCH] hw/arm/virt: remove unused header files

2018-11-06 Thread Hongbo Zhang
On 5 November 2018 at 21:26, Auger Eric wrote: > Hi Hongbo, > > On 10/23/18 12:21 PM, Hongbo Zhang wrote: >> Well, after checking manually, the header files >> "hw/arm/primecell.h" >> "qapi/visitor.h" >> "hw/arm/smmuv3.h" >> are really not used in virt.c, still can be removed. >> >> On 22 October

Re: [Qemu-devel] [PATCH] hw/arm/virt: remove unused header files

2018-11-05 Thread Auger Eric
Hi Hongbo, On 10/23/18 12:21 PM, Hongbo Zhang wrote: > Well, after checking manually, the header files > "hw/arm/primecell.h" > "qapi/visitor.h" > "hw/arm/smmuv3.h" > are really not used in virt.c, still can be removed. > > On 22 October 2018 at 18:17, Hongbo Zhang wrote: >> On 22 October 2018 a

Re: [Qemu-devel] [PATCH] hw/arm/virt: remove unused header files

2018-10-23 Thread Hongbo Zhang
Well, after checking manually, the header files "hw/arm/primecell.h" "qapi/visitor.h" "hw/arm/smmuv3.h" are really not used in virt.c, still can be removed. On 22 October 2018 at 18:17, Hongbo Zhang wrote: > On 22 October 2018 at 09:37, Hongbo Zhang wrote: >> On 19 October 2018 at 19:59, Peter M

Re: [Qemu-devel] [PATCH] hw/arm/virt: remove unused header files

2018-10-22 Thread Hongbo Zhang
On 22 October 2018 at 09:37, Hongbo Zhang wrote: > On 19 October 2018 at 19:59, Peter Maydell wrote: >> On 19 October 2018 at 11:18, Hongbo Zhang wrote: >>> Remove the unused herder files, 'virt' can be compiled and run without >>> including them. >>> >>> Signed-off-by: Hongbo Zhang >>> --- >>>

Re: [Qemu-devel] [PATCH] hw/arm/virt: remove unused header files

2018-10-21 Thread Hongbo Zhang
On 19 October 2018 at 19:59, Peter Maydell wrote: > On 19 October 2018 at 11:18, Hongbo Zhang wrote: >> Remove the unused herder files, 'virt' can be compiled and run without >> including them. >> >> Signed-off-by: Hongbo Zhang >> --- >> hw/arm/virt.c | 8 >> 1 file changed, 8 deletion

Re: [Qemu-devel] [PATCH] hw/arm/virt: remove unused header files

2018-10-19 Thread Peter Maydell
On 19 October 2018 at 11:18, Hongbo Zhang wrote: > Remove the unused herder files, 'virt' can be compiled and run without > including them. > > Signed-off-by: Hongbo Zhang > --- > hw/arm/virt.c | 8 > 1 file changed, 8 deletions(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index

[Qemu-devel] [PATCH] hw/arm/virt: remove unused header files

2018-10-19 Thread Hongbo Zhang
Remove the unused herder files, 'virt' can be compiled and run without including them. Signed-off-by: Hongbo Zhang --- hw/arm/virt.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 9f67782..f0066cb 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -