Re: [Qemu-devel] [PATCH] hw/block: Fix pin-based interrupt behaviour of NVMe

2018-01-08 Thread Hikaru Nishida
Thank you for applying my patch. > I had to resolve conflicts with the tracing patches and chose to keep > the trace points from pci_irq_pulse() for pci_irq_assert(), but didn't > add them to pci_irq_deassert(). Please check if this makes sense to you. It makes sense for now. I will send another

Re: [Qemu-devel] [PATCH] hw/block: Fix pin-based interrupt behaviour of NVMe

2018-01-08 Thread Kevin Wolf
Am 18.12.2017 um 06:00 hat Hikaru Nishida geschrieben: > Pin-based interrupt of NVMe controller did not work properly > because using an obsolated function pci_irq_pulse(). > To fix this, change to use pci_irq_assert() / pci_irq_deassert() > instead of pci_irq_pulse(). > > Signed-off-by: Hikaru Ni

Re: [Qemu-devel] [PATCH] hw/block: Fix pin-based interrupt behaviour of NVMe

2018-01-04 Thread Keith Busch
On Mon, Dec 18, 2017 at 02:00:43PM +0900, Hikaru Nishida wrote: > Pin-based interrupt of NVMe controller did not work properly > because using an obsolated function pci_irq_pulse(). > To fix this, change to use pci_irq_assert() / pci_irq_deassert() > instead of pci_irq_pulse(). Looks good. Thanks

Re: [Qemu-devel] [PATCH] hw/block: Fix pin-based interrupt behaviour of NVMe

2018-01-04 Thread Hikaru Nishida
ping... 2017-12-22 16:31 GMT+09:00 Hikaru Nishida : > ping > http://patchwork.ozlabs.org/patch/849786/ > > 2017-12-18 14:00 GMT+09:00 Hikaru Nishida : >> Pin-based interrupt of NVMe controller did not work properly >> because using an obsolated function pci_irq_pulse(). >> To fix this, change to u

Re: [Qemu-devel] [PATCH] hw/block: Fix pin-based interrupt behaviour of NVMe

2017-12-21 Thread Hikaru Nishida
ping http://patchwork.ozlabs.org/patch/849786/ 2017-12-18 14:00 GMT+09:00 Hikaru Nishida : > Pin-based interrupt of NVMe controller did not work properly > because using an obsolated function pci_irq_pulse(). > To fix this, change to use pci_irq_assert() / pci_irq_deassert() > instead of pci_irq_p

[Qemu-devel] [PATCH] hw/block: Fix pin-based interrupt behaviour of NVMe

2017-12-17 Thread Hikaru Nishida
Pin-based interrupt of NVMe controller did not work properly because using an obsolated function pci_irq_pulse(). To fix this, change to use pci_irq_assert() / pci_irq_deassert() instead of pci_irq_pulse(). Signed-off-by: Hikaru Nishida --- hw/block/nvme.c | 39 ++