Re: [Qemu-devel] [PATCH] hw/block: report when pflash backing file isn't aligned

2019-02-15 Thread Laszlo Ersek
On 02/14/19 23:38, Alex Bennée wrote: > > Laszlo Ersek writes: > >> On 02/14/19 16:57, Alex Bennée wrote: >>> It looks like there was going to be code to check we had some sort of >>> alignment so lets replace it with an actual check. This is a bit more >>> useful than the enigmatic "failed to

Re: [Qemu-devel] [PATCH] hw/block: report when pflash backing file isn't aligned

2019-02-15 Thread Geert Stappers
On Thu, Feb 14, 2019 at 10:38:35PM +, Alex Bennée wrote: > Laszlo Ersek writes: > > On 02/14/19 16:57, Alex Bennée wrote: > >> +/* > >> + * Validate the backing store is the right size for pflash > >> + * devices. It has to be padded to a multiple of the flash block > >> + *

Re: [Qemu-devel] [PATCH] hw/block: report when pflash backing file isn't aligned

2019-02-15 Thread Markus Armbruster
Alex Bennée writes: > Laszlo Ersek writes: > >> On 02/14/19 16:57, Alex Bennée wrote: >>> It looks like there was going to be code to check we had some sort of >>> alignment so lets replace it with an actual check. This is a bit more >>> useful than the enigmatic "failed to read the initial

Re: [Qemu-devel] [PATCH] hw/block: report when pflash backing file isn't aligned

2019-02-14 Thread Alex Bennée
Laszlo Ersek writes: > On 02/14/19 16:57, Alex Bennée wrote: >> It looks like there was going to be code to check we had some sort of >> alignment so lets replace it with an actual check. This is a bit more >> useful than the enigmatic "failed to read the initial flash content" >> when we

Re: [Qemu-devel] [PATCH] hw/block: report when pflash backing file isn't aligned

2019-02-14 Thread Laszlo Ersek
On 02/14/19 16:57, Alex Bennée wrote: > It looks like there was going to be code to check we had some sort of > alignment so lets replace it with an actual check. This is a bit more > useful than the enigmatic "failed to read the initial flash content" > when we attempt to read the number of bytes

[Qemu-devel] [PATCH] hw/block: report when pflash backing file isn't aligned

2019-02-14 Thread Alex Bennée
It looks like there was going to be code to check we had some sort of alignment so lets replace it with an actual check. This is a bit more useful than the enigmatic "failed to read the initial flash content" when we attempt to read the number of bytes the device should have. This is a potential