Re: [Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

2018-11-12 Thread Markus Armbruster
Peter Maydell writes: > On 12 November 2018 at 09:16, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 9 November 2018 at 14:14, Gerd Hoffmann wrote: Broken (segfaultson first keypress) and appearently unused. Signed-off-by: Gerd Hoffmann >> >> Please show the

Re: [Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

2018-11-12 Thread Peter Maydell
On 12 November 2018 at 09:16, Markus Armbruster wrote: > Peter Maydell writes: > >> On 9 November 2018 at 14:14, Gerd Hoffmann wrote: >>> Broken (segfaultson first keypress) and appearently unused. >>> >>> Signed-off-by: Gerd Hoffmann > > Please show the reproducer in the commit message.

Re: [Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

2018-11-12 Thread Thomas Huth
On 2018-11-09 15:14, Gerd Hoffmann wrote: > Broken (segfaultson first keypress) and appearently unused. Broken since QEMU v2.1 (!) already, if I've got that right - please mention that version number, so that it is clear that it is broken since more than two releases (i.e. it has been

Re: [Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

2018-11-12 Thread Markus Armbruster
Peter Maydell writes: > On 9 November 2018 at 14:14, Gerd Hoffmann wrote: >> Broken (segfaultson first keypress) and appearently unused. >> >> Signed-off-by: Gerd Hoffmann Please show the reproducer in the commit message. Stack backtrace wouldn't hurt. >> --- >> include/hw/bt.h | 3 -

Re: [Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

2018-11-09 Thread Paolo Bonzini
On 09/11/2018 15:14, Gerd Hoffmann wrote: > Broken (segfaultson first keypress) and appearently unused. > > Signed-off-by: Gerd Hoffmann No objection, but can we make some effort of, at least, putting the stack backtrace in the commit log? Paolo > --- > include/hw/bt.h | 3 - >

Re: [Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

2018-11-09 Thread Philippe Mathieu-Daudé
Cc'ing Andrzej, the actual author. On 9/11/18 15:14, Gerd Hoffmann wrote: Broken (segfaultson first keypress) and appearently unused. Signed-off-by: Gerd Hoffmann --- include/hw/bt.h | 3 - hw/bt/hid.c | 554 vl.c

Re: [Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

2018-11-09 Thread Peter Maydell
On 9 November 2018 at 14:14, Gerd Hoffmann wrote: > Broken (segfaultson first keypress) and appearently unused. > > Signed-off-by: Gerd Hoffmann > --- > include/hw/bt.h | 3 - > hw/bt/hid.c | 554 > > vl.c| 34

Re: [Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

2018-11-09 Thread Eric Blake
On 11/9/18 8:14 AM, Gerd Hoffmann wrote: Broken (segfaultson first keypress) and appearently unused. s/segfaultson/segfaults on/, s/appearently/apparently/ Also, trailing '.' in the subject line is unusual Signed-off-by: Gerd Hoffmann --- -- Eric Blake, Principal Software Engineer Red

Re: [Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

2018-11-09 Thread Liam Merwick
On 09/11/2018 14:14, Gerd Hoffmann wrote: Broken (segfaultson first keypress) and appearently unused. s/segfaultson/segfaults on/ s/appearently/apparently/ Signed-off-by: Gerd Hoffmann one question at the end, otherwise Reviewed-by: Liam Merwick --- include/hw/bt.h | 3 -

[Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

2018-11-09 Thread Gerd Hoffmann
Broken (segfaultson first keypress) and appearently unused. Signed-off-by: Gerd Hoffmann --- include/hw/bt.h | 3 - hw/bt/hid.c | 554 vl.c| 34 +--- hw/bt/Makefile.objs | 3 +- qemu-options.hx | 9 - 5