Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Fix PC overwriting

2019-01-22 Thread Peter Maydell
On Tue, 22 Jan 2019 at 13:59, Julia Suvorova wrote: > On 21.01.2019 20:24, Peter Maydell wrote: > >> I think that probably what we ought to do is define that: > >> * set_pc has the logic that does whatever is expected > >> when the user sets the PC either by hand or when a > >> ELF file

Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Fix PC overwriting

2019-01-22 Thread Julia Suvorova via Qemu-devel
On 21.01.2019 20:24, Peter Maydell wrote: On Thu, 17 Jan 2019 at 19:27, Peter Maydell wrote: On Thu, 17 Jan 2019 at 10:58, Julia Suvorova wrote: On 17.01.2019 13:13, Stefan Hajnoczi wrote: generic_loader_reset() calls cpu_reset(s->cpu) followed by CPUClass->set_pc(s->cpu, s->addr). ARM's

Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Fix PC overwriting

2019-01-21 Thread Peter Maydell
On Thu, 17 Jan 2019 at 19:27, Peter Maydell wrote: > > On Thu, 17 Jan 2019 at 10:58, Julia Suvorova wrote: > > > > On 17.01.2019 13:13, Stefan Hajnoczi wrote: > > > generic_loader_reset() calls cpu_reset(s->cpu) followed by > > > CPUClass->set_pc(s->cpu, s->addr). > > > > > > ARM's arm_cpu_set_pc

Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Fix PC overwriting

2019-01-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190115143650.15725-1-jus...@mail.ru/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bi

Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Fix PC overwriting

2019-01-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190115143650.15725-1-jus...@mail.ru/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190115143650.15725-1-jus...@mail.ru Subject: [Qemu-devel] [PATCH] hw/core/generic-loader

Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Fix PC overwriting

2019-01-17 Thread Peter Maydell
On Thu, 17 Jan 2019 at 19:27, Peter Maydell wrote: > recent gdb neither emits > 'c addr' nor supports it in its gdbserver implementation ...and I dug about in the gdb git history, and as far as I can tell even back in 2005 or so gdb's gdbserver never supported the 'addr' parameter to 'c' and 's',

Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Fix PC overwriting

2019-01-17 Thread Peter Maydell
On Thu, 17 Jan 2019 at 10:58, Julia Suvorova wrote: > > On 17.01.2019 13:13, Stefan Hajnoczi wrote: > > generic_loader_reset() calls cpu_reset(s->cpu) followed by > > CPUClass->set_pc(s->cpu, s->addr). > > > > ARM's arm_cpu_set_pc() doesn't special-case the Thumb bit (that's only > > done in arm_c

Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Fix PC overwriting

2019-01-17 Thread Julia Suvorova via Qemu-devel
On 17.01.2019 13:13, Stefan Hajnoczi wrote: On Wed, Jan 16, 2019 at 10:05:58PM +0300, Julia Suvorova via Qemu-devel wrote: On 16.01.2019 0:51, Alistair Francis wrote: On Tue, Jan 15, 2019 at 7:04 AM Julia Suvorova via Qemu-devel wrote: If the memory is set using a file, and PC is specified o

Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Fix PC overwriting

2019-01-17 Thread Stefan Hajnoczi
On Wed, Jan 16, 2019 at 10:05:58PM +0300, Julia Suvorova via Qemu-devel wrote: > On 16.01.2019 0:51, Alistair Francis wrote: > > On Tue, Jan 15, 2019 at 7:04 AM Julia Suvorova via Qemu-devel > > wrote: > > > > > > If the memory is set using a file, and PC is specified on the command > > > line, i

Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Fix PC overwriting

2019-01-16 Thread Julia Suvorova via Qemu-devel
On 16.01.2019 0:51, Alistair Francis wrote: On Tue, Jan 15, 2019 at 7:04 AM Julia Suvorova via Qemu-devel wrote: If the memory is set using a file, and PC is specified on the command line, it will be overwritten with the value 'entry'. This is not only illogical, but also incorrect, because th

Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Fix PC overwriting

2019-01-15 Thread Alistair Francis
On Tue, Jan 15, 2019 at 7:04 AM Julia Suvorova via Qemu-devel wrote: > > If the memory is set using a file, and PC is specified on the command > line, it will be overwritten with the value 'entry'. This is not only > illogical, but also incorrect, because the load_ * functions do not take > into a

[Qemu-devel] [PATCH] hw/core/generic-loader: Fix PC overwriting

2019-01-15 Thread Julia Suvorova via Qemu-devel
If the memory is set using a file, and PC is specified on the command line, it will be overwritten with the value 'entry'. This is not only illogical, but also incorrect, because the load_ * functions do not take into account the specifics of the ARM-M PC. Signed-off-by: Julia Suvorova --- hw/co