Re: [Qemu-devel] [PATCH] hw/cpu: core.c can be compiled as common object

2017-06-09 Thread Eduardo Habkost
On Fri, Jun 09, 2017 at 12:03:38PM +1000, David Gibson wrote: > On Thu, Jun 08, 2017 at 04:23:34PM +0200, Juan Quintela wrote: > > Thomas Huth wrote: > > > There does not seem to be any target specific code in core.c, so we can > > > put it into "common-obj" instead of "obj" to compile it only onc

Re: [Qemu-devel] [PATCH] hw/cpu: core.c can be compiled as common object

2017-06-08 Thread David Gibson
On Thu, Jun 08, 2017 at 04:23:34PM +0200, Juan Quintela wrote: > Thomas Huth wrote: > > There does not seem to be any target specific code in core.c, so we can > > put it into "common-obj" instead of "obj" to compile it only once for > > all targets. > > > > Signed-off-by: Thomas Huth > > It com

Re: [Qemu-devel] [PATCH] hw/cpu: core.c can be compiled as common object

2017-06-08 Thread Juan Quintela
Thomas Huth wrote: > There does not seem to be any target specific code in core.c, so we can > put it into "common-obj" instead of "obj" to compile it only once for > all targets. > > Signed-off-by: Thomas Huth It compiles. I can't see anything that is target dependent on core.c. So Reviewed-b

[Qemu-devel] [PATCH] hw/cpu: core.c can be compiled as common object

2017-06-08 Thread Thomas Huth
There does not seem to be any target specific code in core.c, so we can put it into "common-obj" instead of "obj" to compile it only once for all targets. Signed-off-by: Thomas Huth --- hw/cpu/Makefile.objs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/cpu/Makefile.obj