[Qemu-devel] [PATCH] hw/display/tcx: Remove superfluous OBJECT() typecasts

2015-10-15 Thread Thomas Huth
The tcx_initfn() function is already supplied with an Object *obj pointer, so there is no need to cast the state pointer back to an Object pointer all over the place. And while we're at it, also remove the superfluous "return;" statement in this function. Signed-off-by: Thomas Huth --- hw/displa

Re: [Qemu-devel] [PATCH] hw/display/tcx: Remove superfluous OBJECT() typecasts

2015-10-15 Thread Markus Armbruster
Thomas Huth writes: > The tcx_initfn() function is already supplied with an > Object *obj pointer, so there is no need to cast the > state pointer back to an Object pointer all over the > place. And while we're at it, also remove the superfluous > "return;" statement in this function. > > Signed-

Re: [Qemu-devel] [PATCH] hw/display/tcx: Remove superfluous OBJECT() typecasts

2015-10-18 Thread Mark Cave-Ayland
On 15/10/15 09:54, Thomas Huth wrote: > The tcx_initfn() function is already supplied with an > Object *obj pointer, so there is no need to cast the > state pointer back to an Object pointer all over the > place. And while we're at it, also remove the superfluous > "return;" statement in this func

Re: [Qemu-devel] [PATCH] hw/display/tcx: Remove superfluous OBJECT() typecasts

2015-10-19 Thread Markus Armbruster
Mark Cave-Ayland writes: > On 15/10/15 09:54, Thomas Huth wrote: > >> The tcx_initfn() function is already supplied with an >> Object *obj pointer, so there is no need to cast the >> state pointer back to an Object pointer all over the >> place. And while we're at it, also remove the superfluous

Re: [Qemu-devel] [PATCH] hw/display/tcx: Remove superfluous OBJECT() typecasts

2015-10-29 Thread Michael Tokarev
15.10.2015 11:54, Thomas Huth wrote: > The tcx_initfn() function is already supplied with an > Object *obj pointer, so there is no need to cast the > state pointer back to an Object pointer all over the > place. And while we're at it, also remove the superfluous > "return;" statement in this functi