Re: [Qemu-devel] [PATCH] hw/dma: Fix dead code in pl080.c

2017-01-05 Thread Peter Maydell
On 27 December 2016 at 23:11, Sergio Andrés Gómez Del Real wrote: > The patch fixes dead code in pl080_read() and pl080_write() as reported > in bug #1637974. According to ARM's official Technical Reference Manual, > offsets handled by the switch statement are 0x100, 0x104, 0x108, 0x10C > and 0x11

[Qemu-devel] [PATCH] hw/dma: Fix dead code in pl080.c

2016-12-27 Thread Sergio Andrés Gómez Del Real
The patch fixes dead code in pl080_read() and pl080_write() as reported in bug #1637974. According to ARM's official Technical Reference Manual, offsets handled by the switch statement are 0x100, 0x104, 0x108, 0x10C and 0x110, so the solution suggested by the guy who reported the bug is right. Sig

Re: [Qemu-devel] [PATCH] hw/dma: Fix dead code in pl080.c

2016-12-27 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 20161227165947.20184-1-sergio.g.delr...@gmail.com Type: series Subject: [Qemu-devel] [PATCH] hw/dma: Fix dead code in pl080.c === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total

[Qemu-devel] [PATCH] hw/dma: Fix dead code in pl080.c

2016-12-27 Thread Sergio Andrés Gómez Del Real
The patch fixes dead code in pl080_read() and pl080_write() as reported in bug #1637974. According to ARM's official Technical Reference Manual, offsets handled by the switch statement are 0x100, 0x104, 0x108, 0x10C and 0x110, so the solution suggested by the guy who reported the bug is right. Sig