Re: [Qemu-devel] [PATCH] hw/intc/arm_gic: Fix GIC_SET_LEVEL

2014-02-24 Thread Peter Maydell
On 23 February 2014 16:32, Christoffer Dall wrote: > On 21 February 2014 17:03, Christoffer Dall > wrote: >> The GIC_SET_LEVEL macro unfortunately overwrote the entire level >> bitmask instead of just or'ing on the necessary bits, causing active >> level PPIs on a core to clear PPIs on other cor

Re: [Qemu-devel] [PATCH] hw/intc/arm_gic: Fix GIC_SET_LEVEL

2014-02-23 Thread Christoffer Dall
On 21 February 2014 17:03, Christoffer Dall wrote: > The GIC_SET_LEVEL macro unfortunately overwrote the entire level > bitmask instead of just or'ing on the necessary bits, causing active > level PPIs on a core to clear PPIs on other cores. > > I introduced this bug, sorry about that. > Actually

[Qemu-devel] [PATCH] hw/intc/arm_gic: Fix GIC_SET_LEVEL

2014-02-21 Thread Christoffer Dall
The GIC_SET_LEVEL macro unfortunately overwrote the entire level bitmask instead of just or'ing on the necessary bits, causing active level PPIs on a core to clear PPIs on other cores. I introduced this bug, sorry about that. Reported-by: Rob Herring Signed-off-by: Christoffer Dall --- hw/intc