Re: [Qemu-devel] [PATCH] hw/intc/arm_gicv3: fix an extra left-shift when reading IPRIORITYR

2018-06-15 Thread Peter Maydell
On 14 June 2018 at 06:48, Amol Surati wrote: > When either GICD_IPRIORITYR or GICR_IPRIORITYR is read as a 32-bit > register, the post left-shift operator in the for loop causes an > extra shift after the least significant byte has been placed. > > The 32-bit value actually returned is therefore

[Qemu-devel] [PATCH] hw/intc/arm_gicv3: fix an extra left-shift when reading IPRIORITYR

2018-06-14 Thread Amol Surati
When either GICD_IPRIORITYR or GICR_IPRIORITYR is read as a 32-bit register, the post left-shift operator in the for loop causes an extra shift after the least significant byte has been placed. The 32-bit value actually returned is therefore the expected value shifted left by 8 bits.