On Thu, Feb 14, 2013 at 08:54:20AM +0100, Antoine Mathys wrote:
This patch consolidates the bit twidling involved in reading and
writing the time registers to four functions that are used consistently.
This also has the effect of fixing bug 1090558.
Signed-off-by: Antoine Mathys
Il 14/02/2013 08:54, Antoine Mathys ha scritto:
This patch consolidates the bit twidling involved in reading and
writing the time registers to four functions that are used consistently.
This also has the effect of fixing bug 1090558.
Signed-off-by: Antoine Mathys barsa...@gmail.com
---
On 02/14/2013 10:30 AM, Paolo Bonzini wrote:
Nice. Do you have a testcase?
No, but the refactoring makes the code very easy to audit.
Please also test this patch with the two rtc-test patches at
http://thread.gmane.org/gmane.comp.emulators.qemu/188244.
I did and the tests pass.
Il 14/02/2013 10:45, Antoine Mathys ha scritto:
Nice. Do you have a testcase?
No, but the refactoring makes the code very easy to audit.
I asked because I tried to reproduce the launchpad bug and failed.
Please also test this patch with the two rtc-test patches at
This patch consolidates the bit twidling involved in reading and
writing the time registers to four functions that are used consistently.
This also has the effect of fixing bug 1090558.
Signed-off-by: Antoine Mathys barsa...@gmail.com
---
hw/mc146818rtc.c | 163
