Re: [Qemu-devel] [PATCH] hw/pci: fix error flow in pci multifunction init

2014-01-23 Thread Marcel Apfelbaum
On Tue, 2014-01-21 at 18:37 +0200, Marcel Apfelbaum wrote: Scenario: - There is a non multifunction pci device A on 00:0X.0. - Hot-plug another multifunction pci device B at 00:0X.1. - The operation will fail of course. - Try to hot-plug the B device 2-3 more times, qemu will crash.

Re: [Qemu-devel] [PATCH] hw/pci: fix error flow in pci multifunction init

2014-01-23 Thread Markus Armbruster
Marcel Apfelbaum marce...@redhat.com writes: Scenario: - There is a non multifunction pci device A on 00:0X.0. - Hot-plug another multifunction pci device B at 00:0X.1. - The operation will fail of course. - Try to hot-plug the B device 2-3 more times, qemu will crash. Reason: The

Re: [Qemu-devel] [PATCH] hw/pci: fix error flow in pci multifunction init

2014-01-23 Thread Michael S. Tsirkin
On Tue, Jan 21, 2014 at 06:37:51PM +0200, Marcel Apfelbaum wrote: Scenario: - There is a non multifunction pci device A on 00:0X.0. - Hot-plug another multifunction pci device B at 00:0X.1. - The operation will fail of course. - Try to hot-plug the B device 2-3 more times, qemu will

[Qemu-devel] [PATCH] hw/pci: fix error flow in pci multifunction init

2014-01-21 Thread Marcel Apfelbaum
Scenario: - There is a non multifunction pci device A on 00:0X.0. - Hot-plug another multifunction pci device B at 00:0X.1. - The operation will fail of course. - Try to hot-plug the B device 2-3 more times, qemu will crash. Reason: The error flow leaves the B's address space into global