[Qemu-devel] [PATCH] hw/ppc/spapr_iommu: Fix the check for invalid upper bits in liobn

2015-04-20 Thread Thomas Huth
The check "liobn & 0xULL" in spapr_tce_find_by_liobn() is completely useless since liobn is only declared as an uint32_t parameter. Fix this by using target_ulong instead (this is what most of the callers of this function are using, too). And while we're at it, change the error mess

Re: [Qemu-devel] [PATCH] hw/ppc/spapr_iommu: Fix the check for invalid upper bits in liobn

2015-04-20 Thread David Gibson
On Mon, Apr 20, 2015 at 05:34:56PM +0200, Thomas Huth wrote: > The check "liobn & 0xULL" in spapr_tce_find_by_liobn() > is completely useless since liobn is only declared as an uint32_t > parameter. Fix this by using target_ulong instead (this is what most > of the callers of this f

Re: [Qemu-devel] [PATCH] hw/ppc/spapr_iommu: Fix the check for invalid upper bits in liobn

2015-04-20 Thread Thomas Huth
Am Tue, 21 Apr 2015 10:24:48 +1000 schrieb David Gibson : > On Mon, Apr 20, 2015 at 05:34:56PM +0200, Thomas Huth wrote: > > The check "liobn & 0xULL" in spapr_tce_find_by_liobn() > > is completely useless since liobn is only declared as an uint32_t > > parameter. Fix this by using