Re: [Qemu-devel] [PATCH] hw/timer/mt48t59: Fix bit-rotten NVRAM_PRINTF format strings

2018-02-03 Thread Mark Cave-Ayland
On 02/02/18 08:15, Thomas Huth wrote: When compiling with NVRAM_PRINTF enabled, gcc currently bails out with: CC hw/timer/m48t59.o CC hw/timer/m48t59-isa.o hw/timer/m48t59.c: In function ‘NVRAM_writeb’: hw/timer/m48t59.c:460:5: error: format ‘%x’ expects argument of type ‘unsign

Re: [Qemu-devel] [PATCH] hw/timer/mt48t59: Fix bit-rotten NVRAM_PRINTF format strings

2018-02-02 Thread Philippe Mathieu-Daudé
Hi Thomas, On 02/02/2018 05:15 AM, Thomas Huth wrote: > When compiling with NVRAM_PRINTF enabled, gcc currently bails out with: > > CC hw/timer/m48t59.o > CC hw/timer/m48t59-isa.o > hw/timer/m48t59.c: In function ‘NVRAM_writeb’: > hw/timer/m48t59.c:460:5: error: format ‘%x’ expects

[Qemu-devel] [PATCH] hw/timer/mt48t59: Fix bit-rotten NVRAM_PRINTF format strings

2018-02-02 Thread Thomas Huth
When compiling with NVRAM_PRINTF enabled, gcc currently bails out with: CC hw/timer/m48t59.o CC hw/timer/m48t59-isa.o hw/timer/m48t59.c: In function ‘NVRAM_writeb’: hw/timer/m48t59.c:460:5: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘hwaddr’