Re: [Qemu-devel] [PATCH] hw/timer: Compile devices not target-dependent as common objects

2019-05-08 Thread Paolo Bonzini
On 06/05/19 03:06, Philippe Mathieu-Daudé wrote: >> By the way, I was surprised to see TARGET_FMT_plx there, since I first >> thought that this would be a target-specific define, too. But apparently >> it is not. Very confusing. I'd suggest to rename that to HWADDR_FMT_plx >> instead, what do you

Re: [Qemu-devel] [PATCH] hw/timer: Compile devices not target-dependent as common objects

2019-05-06 Thread Philippe Mathieu-Daudé
On 5/6/19 6:10 AM, Thomas Huth wrote: > On 05/05/2019 20.07, Philippe Mathieu-Daudé wrote: >> All these devices do not contain any target-specific code. While >> most of them are arch-specific, they are shared between different >> targets of the same arch family (ARM and AArch64, MIPS32/MIPS64, >>

Re: [Qemu-devel] [PATCH] hw/timer: Compile devices not target-dependent as common objects

2019-05-05 Thread Thomas Huth
On 05/05/2019 20.07, Philippe Mathieu-Daudé wrote: > All these devices do not contain any target-specific code. While > most of them are arch-specific, they are shared between different > targets of the same arch family (ARM and AArch64, MIPS32/MIPS64, > multiple endianess, ...). > Put them into

[Qemu-devel] [PATCH] hw/timer: Compile devices not target-dependent as common objects

2019-05-05 Thread Philippe Mathieu-Daudé
All these devices do not contain any target-specific code. While most of them are arch-specific, they are shared between different targets of the same arch family (ARM and AArch64, MIPS32/MIPS64, multiple endianess, ...). Put them into common-obj-y to compile them once for all targets.