Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

On Fri, Oct 30, 2015 at 11:59:29AM +0100, Gerd Hoffmann wrote: > > > What bothers me is that you have no qualms about making latency on > > > everyone's system worse. > > > > How do you know it makes sound on other people's systems worse? If you have > > actually done any testing, I would like to

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

Hi, > > Higher chance is with video playback. lip sync issues might show up, > > although you probably still have to watch carefully to actually notice. > > Regarding the video playback workload: video playback is not a > low-latency audio use case. That's why you won't notice any difference

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

Hi, [ context for spice folks: patch was added to qemu increasing usb-audio default buffer size ] > > What bothers me is that you have no qualms about making latency on > > everyone's system worse. > > How do you know it makes sound on other people's systems worse? If you have > actually

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

On Wed, Oct 28, 2015 at 09:59:32AM -0400, Programmingkid wrote: > > On Oct 28, 2015, at 6:58 AM, Stefan Hajnoczi wrote: > > > On Mon, Oct 26, 2015 at 01:24:00PM +0100, Gerd Hoffmann wrote: > >>> So this change would make real-time audio feel laggy. > >> > >> That is secondary if the sound

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

On Oct 29, 2015, at 11:08 AM, Stefan Hajnoczi wrote: > On Wed, Oct 28, 2015 at 09:59:32AM -0400, Programmingkid wrote: >> >> On Oct 28, 2015, at 6:58 AM, Stefan Hajnoczi wrote: >> >>> On Mon, Oct 26, 2015 at 01:24:00PM +0100, Gerd Hoffmann wrote: > So this change would make real-time audio

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

Hi, > Is the problem the host sound API, QEMU's audio/mixing infrastructure, > or guest responsiveness? Didn't check in deep this time, but usually none of the above. Latency problems *anywhere* in qemu can cause this, because the latency spikes cause the guest not being scheduled for too

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

On Oct 28, 2015, at 6:58 AM, Stefan Hajnoczi wrote: > On Mon, Oct 26, 2015 at 01:24:00PM +0100, Gerd Hoffmann wrote: >>> So this change would make real-time audio feel laggy. >> >> That is secondary if the sound quality is bad due to constant overruns >> and underruns ... > > This is like

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

On Mon, Oct 26, 2015 at 01:24:00PM +0100, Gerd Hoffmann wrote: > > So this change would make real-time audio feel laggy. > > That is secondary if the sound quality is bad due to constant overruns > and underruns ... This is like sweeping network performance problems under the rug by increasing

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

On Fri, Oct 16, 2015 at 09:54:12AM -0400, Programmingkid wrote: > > On Oct 16, 2015, at 8:15 AM, Stefan Hajnoczi wrote: > > > On Tue, Sep 22, 2015 at 07:32:01PM -0400, Programmingkid wrote: > >> The USB audio card would not play audio well because its buffer was too > >> small. > >> Increasing

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

Hi, > So this change would make real-time audio feel laggy. That is secondary if the sound quality is bad due to constant overruns and underruns ... > Unless Gerd has a > strong feeling that it's an improvement for QEMU, I wouldn't merge this > change. The change is merged. cheers, Gerd

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

On Oct 26, 2015, at 7:00 AM, Stefan Hajnoczi wrote: > On Fri, Oct 16, 2015 at 09:54:12AM -0400, Programmingkid wrote: >> >> On Oct 16, 2015, at 8:15 AM, Stefan Hajnoczi wrote: >> >>> On Tue, Sep 22, 2015 at 07:32:01PM -0400, Programmingkid wrote: The USB audio card would not play audio

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

On Oct 26, 2015, at 8:24 AM, Gerd Hoffmann wrote: > Hi, > >> So this change would make real-time audio feel laggy. > > That is secondary if the sound quality is bad due to constant overruns > and underruns ... > >> Unless Gerd has a >> strong feeling that it's an improvement for QEMU, I

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

On Tue, Sep 22, 2015 at 07:32:01PM -0400, Programmingkid wrote: > The USB audio card would not play audio well because its buffer was too > small. > Increasing it made it play perfectly. All the crackling and dropouts are > gone. > > Signed-off-by: John Arbuckle >

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

On Oct 16, 2015, at 8:15 AM, Stefan Hajnoczi wrote: > On Tue, Sep 22, 2015 at 07:32:01PM -0400, Programmingkid wrote: >> The USB audio card would not play audio well because its buffer was too >> small. >> Increasing it made it play perfectly. All the crackling and dropouts are >> gone. >>

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

On Oct 16, 2015, at 10:00 AM, Peter Maydell wrote: > On 16 October 2015 at 14:54, Programmingkid wrote: >> >> On Oct 16, 2015, at 8:15 AM, Stefan Hajnoczi wrote: >>> Gerd might have an opinion on whether that is okay or not. >> >> I doubt it. I don't even think he

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

On 16 October 2015 at 14:54, Programmingkid wrote: > > On Oct 16, 2015, at 8:15 AM, Stefan Hajnoczi wrote: >> Gerd might have an opinion on whether that is okay or not. > > I doubt it. I don't even think he is with QEMU anymore. He doesn't > even answer simple emails.

[Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

The USB audio card would not play audio well because its buffer was too small. Increasing it made it play perfectly. All the crackling and dropouts are gone. Signed-off-by: John Arbuckle --- This patch was tested on qemu-system-ppc running Linux and