Re: [Qemu-devel] [PATCH] hw/xics: Fix one-bit signed bitfields

2012-09-22 Thread Stefan Weil
Am 04.09.2012 22:53, schrieb Peter Maydell: On 4 September 2012 21:30, Stefan Weil wrote: Report from smatch: xics.c:169:19: error: dubious one-bit signed bitfield xics.c:170:15: error: dubious one-bit signed bitfield xics.c:171:19: error: dubious one-bit signed bitfield xics.c:172:25: error:

Re: [Qemu-devel] [PATCH] hw/xics: Fix one-bit signed bitfields

2012-09-04 Thread Peter Maydell
On 4 September 2012 21:30, Stefan Weil wrote: > Report from smatch: > > xics.c:169:19: error: dubious one-bit signed bitfield > xics.c:170:15: error: dubious one-bit signed bitfield > xics.c:171:19: error: dubious one-bit signed bitfield > xics.c:172:25: error: dubious one-bit signed bitfield > >

[Qemu-devel] [PATCH] hw/xics: Fix one-bit signed bitfields

2012-09-04 Thread Stefan Weil
Report from smatch: xics.c:169:19: error: dubious one-bit signed bitfield xics.c:170:15: error: dubious one-bit signed bitfield xics.c:171:19: error: dubious one-bit signed bitfield xics.c:172:25: error: dubious one-bit signed bitfield Instead of replacing 'int' by 'unsigned', 'bool' was used bec