Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-10-04 Thread Hannes Reinecke
On 09/13/2012 08:24 AM, Paolo Bonzini wrote: Il 12/09/2012 15:58, Anthony Liguori ha scritto: Why would someone use this verses megasas vs. LSI vs virtio-scsi? LSI is dead. Compare it to IDE. virtio-scsi has the highest performance, but it is not supported on all guests. Compare it to virti

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-10-01 Thread Paolo Bonzini
Il 29/09/2012 16:35, Don Slutz ha scritto: >> > How important is the big endian support? > > lsi53c895a.c says: > > /* ??? Need to check if the {read,write}[wl] routines work properly on >big-endian targets. */ > > I could do the same, I.E. code it up and submit it un-tested on big > endian

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-29 Thread Don Slutz
On 09/13/12 16:57, Anthony Liguori wrote: "Michael S. Tsirkin" writes: On Tue, Sep 11, 2012 at 01:00:13PM -0400, Don Slutz wrote: +if (next_chain_offset) { +MptSGEntryChain sgec; +cpu_physical_memory_read(seg_start_pa + next_chain_offset, +

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-13 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Tue, Sep 11, 2012 at 01:00:13PM -0400, Don Slutz wrote: >> +if (next_chain_offset) { >> +MptSGEntryChain sgec; >> +cpu_physical_memory_read(seg_start_pa + next_chain_offset, >> +&sgec, sizeof(Mpt

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-13 Thread Don Slutz
On 09/12/12 02:58, Gerhard Wiesinger wrote: On 11.09.2012 19:00, Don Slutz wrote: Add LSI53C1030, SAS1068, SAS1068e. Based on code from "VirtualBox Open Source Edition". Based on QEMU MegaRAID SAS 8708EM2. This is a common VMware disk controller. SEABIOS change for booting is in the works.

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-13 Thread Michael S. Tsirkin
On Tue, Sep 11, 2012 at 01:00:13PM -0400, Don Slutz wrote: > +if (next_chain_offset) { > +MptSGEntryChain sgec; > +cpu_physical_memory_read(seg_start_pa + next_chain_offset, > +&sgec, sizeof(MptSGEntryChain)); > +as

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-13 Thread Anthony Liguori
Paolo Bonzini writes: > Il 12/09/2012 15:58, Anthony Liguori ha scritto: >> Why would someone use this verses megasas vs. LSI vs virtio-scsi? > > LSI is dead. Compare it to IDE. > > virtio-scsi has the highest performance, but it is not supported on all > guests. Compare it to virtio-blk. > > T

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-13 Thread Don Slutz
On 09/12/12 11:38, Avi Kivity wrote: On 09/11/2012 08:00 PM, Don Slutz wrote: Add LSI53C1030, SAS1068, SAS1068e. Based on code from "VirtualBox Open Source Edition". Based on QEMU MegaRAID SAS 8708EM2. This is a common VMware disk controller. SEABIOS change for booting is in the works. Test

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-13 Thread Don Slutz
On 09/12/12 09:58, Anthony Liguori wrote: Kevin Wolf writes: Am 12.09.2012 01:50, schrieb Michael S. Tsirkin: On Tue, Sep 11, 2012 at 01:00:13PM -0400, Don Slutz wrote: Add LSI53C1030, SAS1068, SAS1068e. Based on code from "VirtualBox Open Source Edition". Based on QEMU MegaRAID SAS 8708EM

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-12 Thread Paolo Bonzini
Il 12/09/2012 15:58, Anthony Liguori ha scritto: > Why would someone use this verses megasas vs. LSI vs virtio-scsi? LSI is dead. Compare it to IDE. virtio-scsi has the highest performance, but it is not supported on all guests. Compare it to virtio-blk. This vs. megasas is a good question; bo

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-12 Thread Avi Kivity
On 09/11/2012 08:00 PM, Don Slutz wrote: > Add LSI53C1030, SAS1068, SAS1068e. Based on code from "VirtualBox Open > Source Edition". > Based on QEMU MegaRAID SAS 8708EM2. > > This is a common VMware disk controller. > > SEABIOS change for booting is in the works. > > Tested with Fedora 16, 17.

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-12 Thread Anthony Liguori
Kevin Wolf writes: > Am 12.09.2012 01:50, schrieb Michael S. Tsirkin: >> On Tue, Sep 11, 2012 at 01:00:13PM -0400, Don Slutz wrote: >>> Add LSI53C1030, SAS1068, SAS1068e. Based on code from "VirtualBox Open >>> Source Edition". >>> Based on QEMU MegaRAID SAS 8708EM2. >>> >>> This is a common VM

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-12 Thread Kevin Wolf
Am 12.09.2012 01:50, schrieb Michael S. Tsirkin: > On Tue, Sep 11, 2012 at 01:00:13PM -0400, Don Slutz wrote: >> Add LSI53C1030, SAS1068, SAS1068e. Based on code from "VirtualBox Open >> Source Edition". >> Based on QEMU MegaRAID SAS 8708EM2. >> >> This is a common VMware disk controller. > > I

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-12 Thread Gerhard Wiesinger
On 11.09.2012 19:00, Don Slutz wrote: Add LSI53C1030, SAS1068, SAS1068e. Based on code from "VirtualBox Open Source Edition". Based on QEMU MegaRAID SAS 8708EM2. This is a common VMware disk controller. SEABIOS change for booting is in the works. Tested with Fedora 16, 17. CentoOS 6. Window

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-11 Thread Paolo Bonzini
Il 12/09/2012 01:50, Michael S. Tsirkin ha scritto: > +static void lsilogic_abort_command(LsilogicCmd *cmd) > +{ > +if (cmd->req) { > +scsi_req_cancel(cmd->req); > +cmd->req = NULL; > +} > +} This only needs to be cmd->req = NULL. > > +if (cmd) { > +lsilogic_a