Re: [Qemu-devel] [PATCH] hw: dead code removal

2017-03-21 Thread Cornelia Huck
On Tue, 21 Mar 2017 13:05:40 +0100 Thomas Huth wrote: > On 20.03.2017 19:00, Anton Volkov wrote: > > Made functions *_exit in hw/ return void instead of int (they returned 0 > > all the time) > > and removed related return value checks > > > > Signed-off-by: Anton Volkov

Re: [Qemu-devel] [PATCH] hw: dead code removal

2017-03-21 Thread Thomas Huth
On 20.03.2017 19:00, Anton Volkov wrote: > Made functions *_exit in hw/ return void instead of int (they returned 0 all > the time) > and removed related return value checks > > Signed-off-by: Anton Volkov > --- > hw/audio/hda-codec.c | 3 +-- >

Re: [Qemu-devel] [PATCH] hw: dead code removal

2017-03-21 Thread Markus Armbruster
Paolo Bonzini writes: > On 21/03/2017 10:37, Markus Armbruster wrote: >> Four related changes, really: >> >> 1. HDACodecDeviceClass method exit() >> 2. VirtIOCCWDeviceClass method exit() >> 3. DeviceClass method exit() >> 4. SCLPEventClass method exit() >> >> Regarding 3:

Re: [Qemu-devel] [PATCH] hw: dead code removal

2017-03-21 Thread Paolo Bonzini
On 21/03/2017 10:37, Markus Armbruster wrote: > Four related changes, really: > > 1. HDACodecDeviceClass method exit() > 2. VirtIOCCWDeviceClass method exit() > 3. DeviceClass method exit() > 4. SCLPEventClass method exit() > > Regarding 3: method exit() needs to go. Your patch shows there

Re: [Qemu-devel] [PATCH] hw: dead code removal

2017-03-21 Thread Markus Armbruster
First of all, subject "hw: dead code removal" is awfully vague. Anton Volkov writes: > Made functions *_exit in hw/ return void instead of int (they returned 0 all > the time) > and removed related return value checks > > Signed-off-by: Anton Volkov > ---

Re: [Qemu-devel] [PATCH] hw: dead code removal

2017-03-21 Thread Frederic Konrad
Hi, On 03/20/2017 07:00 PM, Anton Volkov wrote: > Made functions *_exit in hw/ return void instead of int (they returned 0 all > the time) > and removed related return value checks > > Signed-off-by: Anton Volkov > --- > hw/audio/hda-codec.c | 3 +-- >

Re: [Qemu-devel] [PATCH] hw: dead code removal

2017-03-21 Thread Cornelia Huck
On Mon, 20 Mar 2017 21:00:24 +0300 Anton Volkov wrote: > Made functions *_exit in hw/ return void instead of int (they returned 0 all > the time) > and removed related return value checks Makes sense, I guess. Better make the title "hw: make exit callbacks void" or so,

[Qemu-devel] [PATCH] hw: dead code removal

2017-03-20 Thread Anton Volkov
Made functions *_exit in hw/ return void instead of int (they returned 0 all the time) and removed related return value checks Signed-off-by: Anton Volkov --- hw/audio/hda-codec.c | 3 +-- hw/audio/intel-hda.c | 3 +-- hw/audio/intel-hda.h