Re: [Qemu-devel] [PATCH] hw: fw_cfg: Improve error message when can't load splash file

2018-12-11 Thread Philippe Mathieu-Daudé
On 11/1/18 7:02 AM, Li Qiang wrote: > read_splashfile() reports "failed to read splash file" without > further details. Get the details from g_file_get_contents(), and > include them in the error message. Also remove unnecessary 'res' > variable. > > Signed-off-by: Li Qiang > --- >

Re: [Qemu-devel] [PATCH] hw: fw_cfg: Improve error message when can't load splash file

2018-11-26 Thread Markus Armbruster
Li Qiang writes: > read_splashfile() reports "failed to read splash file" without > further details. Get the details from g_file_get_contents(), and > include them in the error message. Also remove unnecessary 'res' > variable. > > Signed-off-by: Li Qiang > --- > hw/nvram/fw_cfg.c | 7 +++

Re: [Qemu-devel] [PATCH] hw: fw_cfg: Improve error message when can't load splash file

2018-11-26 Thread Li Qiang
Hello Paolo, Philippe Seems this patch has been lost... I think Philippe can merge it for 4.0, right? Also pls notice the following fw_cfg patchset. -->https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04097.html Thanks, Li Qiang Li Qiang 于2018年11月1日周四 下午2:02写道: > read_splashfile()

[Qemu-devel] [PATCH] hw: fw_cfg: Improve error message when can't load splash file

2018-11-01 Thread Li Qiang
read_splashfile() reports "failed to read splash file" without further details. Get the details from g_file_get_contents(), and include them in the error message. Also remove unnecessary 'res' variable. Signed-off-by: Li Qiang --- hw/nvram/fw_cfg.c | 7 +++ 1 file changed, 3 insertions(+),