Re: [Qemu-devel] [PATCH] i.MX: Fix FEC/ENET receive funtions

2018-01-12 Thread Jean-Christophe Dubois
Le 2018-01-12 18:08, Peter Maydell a écrit : On 10 January 2018 at 20:38, Jean-Christophe Dubois wrote: The actual imx_eth_enable_rx() function is buggy. It updates s->regs[ENET_RDAR] after calling qemu_flush_queued_packets(). qemu_flush_queued_packets() is going to call imx_XXX_receive() w

Re: [Qemu-devel] [PATCH] i.MX: Fix FEC/ENET receive funtions

2018-01-12 Thread Peter Maydell
On 10 January 2018 at 20:38, Jean-Christophe Dubois wrote: > The actual imx_eth_enable_rx() function is buggy. > > It updates s->regs[ENET_RDAR] after calling qemu_flush_queued_packets(). > > qemu_flush_queued_packets() is going to call imx_XXX_receive() which itself > is going to call imx_eth_en

[Qemu-devel] [PATCH] i.MX: Fix FEC/ENET receive funtions

2018-01-10 Thread Jean-Christophe Dubois
The actual imx_eth_enable_rx() function is buggy. It updates s->regs[ENET_RDAR] after calling qemu_flush_queued_packets(). qemu_flush_queued_packets() is going to call imx_XXX_receive() which itself is going to call imx_eth_enable_rx(). By updating s->regs[ENET_RDAR] after calling qemu_flush_que