Re: [Qemu-devel] [PATCH] i.MX31: Fix PRCS bit test

2013-06-25 Thread Peter Maydell
On 9 June 2013 21:44, Stefan Weil wrote: > cppcheck detected a condition which was always false. > > According to the MCIMX31 Reference Manual, the PRCS bits have to be 01 > to select the Frequency Pre-Multiplier (FPM). PRCS uses bits 1 and 2, > so we have to test for 2. > > Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH] i.MX31: Fix PRCS bit test

2013-06-09 Thread Peter Chubb
> "Stefan" == Stefan Weil writes: Stefan> cppcheck detected a condition which was always false. Stefan> According to the MCIMX31 Reference Manual, the PRCS bits have Stefan> to be 01 to select the Frequency Pre-Multiplier (FPM). PRCS Stefan> uses bits 1 and 2, so we have to test for 2. Good

[Qemu-devel] [PATCH] i.MX31: Fix PRCS bit test

2013-06-09 Thread Stefan Weil
cppcheck detected a condition which was always false. According to the MCIMX31 Reference Manual, the PRCS bits have to be 01 to select the Frequency Pre-Multiplier (FPM). PRCS uses bits 1 and 2, so we have to test for 2. Signed-off-by: Stefan Weil --- hw/misc/imx_ccm.c |2 +- 1 file changed