Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-18 Thread Eduardo Habkost
On Sat, Jun 15, 2019 at 05:05:05PM -0300, Eduardo Habkost wrote: > The current default value for hv-spinlocks is 0x (meaning > "never retry"). However, the value is stored as a signed > integer, making the getter of the hv-spinlocks QOM property > return -1 instead of 0x. > > Fix

Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-18 Thread Vadim Rozenfeld
On Tue, 2019-06-18 at 10:35 +, Roman Kagan wrote: > On Tue, Jun 18, 2019 at 11:24:57AM +1000, Vadim Rozenfeld wrote: > > On Mon, 2019-06-17 at 14:49 -0300, Eduardo Habkost wrote: > > > On Mon, Jun 17, 2019 at 05:32:13PM +, Roman Kagan wrote: > > > > On Mon, Jun 17, 2019 at 11:23:01AM

Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-18 Thread Roman Kagan
On Tue, Jun 18, 2019 at 10:35:05AM +, Roman Kagan wrote: > On Tue, Jun 18, 2019 at 11:24:57AM +1000, Vadim Rozenfeld wrote: > > On Mon, 2019-06-17 at 14:49 -0300, Eduardo Habkost wrote: > > > On Mon, Jun 17, 2019 at 05:32:13PM +, Roman Kagan wrote: > > > > On Mon, Jun 17, 2019 at

Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-18 Thread Roman Kagan
On Tue, Jun 18, 2019 at 11:24:57AM +1000, Vadim Rozenfeld wrote: > On Mon, 2019-06-17 at 14:49 -0300, Eduardo Habkost wrote: > > On Mon, Jun 17, 2019 at 05:32:13PM +, Roman Kagan wrote: > > > On Mon, Jun 17, 2019 at 11:23:01AM -0300, Eduardo Habkost wrote: > > > > On Mon, Jun 17, 2019 at

Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-17 Thread Vadim Rozenfeld
On Mon, 2019-06-17 at 14:49 -0300, Eduardo Habkost wrote: > On Mon, Jun 17, 2019 at 05:32:13PM +, Roman Kagan wrote: > > On Mon, Jun 17, 2019 at 11:23:01AM -0300, Eduardo Habkost wrote: > > > On Mon, Jun 17, 2019 at 01:48:59PM +, Roman Kagan wrote: > > > > On Sat, Jun 15, 2019 at

Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-17 Thread Eduardo Habkost
On Mon, Jun 17, 2019 at 05:32:13PM +, Roman Kagan wrote: > On Mon, Jun 17, 2019 at 11:23:01AM -0300, Eduardo Habkost wrote: > > On Mon, Jun 17, 2019 at 01:48:59PM +, Roman Kagan wrote: > > > On Sat, Jun 15, 2019 at 05:05:05PM -0300, Eduardo Habkost wrote: > > > > The current default value

Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-17 Thread Roman Kagan
On Mon, Jun 17, 2019 at 11:23:01AM -0300, Eduardo Habkost wrote: > On Mon, Jun 17, 2019 at 01:48:59PM +, Roman Kagan wrote: > > On Sat, Jun 15, 2019 at 05:05:05PM -0300, Eduardo Habkost wrote: > > > The current default value for hv-spinlocks is 0x (meaning > > > "never retry").

Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-17 Thread Eduardo Habkost
On Mon, Jun 17, 2019 at 01:48:59PM +, Roman Kagan wrote: > On Sat, Jun 15, 2019 at 05:05:05PM -0300, Eduardo Habkost wrote: > > The current default value for hv-spinlocks is 0x (meaning > > "never retry"). However, the value is stored as a signed > > integer, making the getter of the

Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-17 Thread Roman Kagan
On Sat, Jun 15, 2019 at 05:05:05PM -0300, Eduardo Habkost wrote: > The current default value for hv-spinlocks is 0x (meaning > "never retry"). However, the value is stored as a signed > integer, making the getter of the hv-spinlocks QOM property > return -1 instead of 0x. > > Fix

Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-17 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > The current default value for hv-spinlocks is 0x (meaning > "never retry"). However, the value is stored as a signed > integer, making the getter of the hv-spinlocks QOM property > return -1 instead of 0x. > > Fix this by changing the type of

[Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-15 Thread Eduardo Habkost
The current default value for hv-spinlocks is 0x (meaning "never retry"). However, the value is stored as a signed integer, making the getter of the hv-spinlocks QOM property return -1 instead of 0x. Fix this by changing the type of X86CPU::hyperv_spinlock_attempts to uint32_t.