Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2015-05-26 Thread Paolo Bonzini
On 24/05/2015 16:43, Jan Kiszka wrote: > diff --git a/target-i386/translate.c b/target-i386/translate.c > index 305ce50..57b607d 100644 > --- a/target-i386/translate.c > +++ b/target-i386/translate.c > @@ -8006,6 +8006,7 @@ static inline void > gen_intermediate_code_internal(X86CPU *cpu, >

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2015-05-24 Thread Jan Kiszka
On 2015-01-12 09:55, Paolo Bonzini wrote: > On 12/01/2015 09:30, Jan Kiszka wrote: >> I think this would only cure a symptom, but it doesn't explain why we >> now hit cpu_handle_guest_debug which we do not before the patch: > > That means we now exit with EXCP_DEBUG and we didn't before? > > Some

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 09:30, Jan Kiszka wrote: > I think this would only cure a symptom, but it doesn't explain why we > now hit cpu_handle_guest_debug which we do not before the patch: That means we now exit with EXCP_DEBUG and we didn't before? Something like this would be a more complete fix (it wor

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2015-01-12 Thread Jan Kiszka
On 2015-01-12 09:26, Pavel Dovgaluk wrote: >> From: Jan Kiszka [mailto:jan.kis...@siemens.com] >> On 2014-10-22 13:38, Pavel Dovgalyuk wrote: >>> This patch fixes instructions counting when execution is stopped on >>> breakpoint (e.g. set from gdb). Without a patch extra instruction is >>> transla

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2015-01-12 Thread Pavel Dovgaluk
> From: Jan Kiszka [mailto:jan.kis...@siemens.com] > On 2014-10-22 13:38, Pavel Dovgalyuk wrote: > > This patch fixes instructions counting when execution is stopped on > > breakpoint (e.g. set from gdb). Without a patch extra instruction is > > translated > > and icount is incremented by invalid

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2015-01-12 Thread Jan Kiszka
On 2014-10-22 13:38, Pavel Dovgalyuk wrote: > This patch fixes instructions counting when execution is stopped on > breakpoint (e.g. set from gdb). Without a patch extra instruction is > translated > and icount is incremented by invalid value (which equals to number of > executed instructions + 1)

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2014-10-31 Thread Paolo Bonzini
On 22/10/2014 13:38, Pavel Dovgalyuk wrote: > This patch fixes instructions counting when execution is stopped on > breakpoint (e.g. set from gdb). Without a patch extra instruction is > translated > and icount is incremented by invalid value (which equals to number of > executed instructions + 1)

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2014-10-23 Thread Pavel Dovgaluk
> From: Frederic Konrad [mailto:fred.kon...@greensocs.com] > On 23/10/2014 09:52, Pavel Dovgaluk wrote: > >> From: Frederic Konrad [mailto:fred.kon...@greensocs.com] > >> On 23/10/2014 07:57, Pavel Dovgaluk wrote: > From: Frederic Konrad [mailto:fred.kon...@greensocs.com] > On 22/10/2014

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2014-10-23 Thread Frederic Konrad
On 23/10/2014 09:52, Pavel Dovgaluk wrote: From: Frederic Konrad [mailto:fred.kon...@greensocs.com] On 23/10/2014 07:57, Pavel Dovgaluk wrote: From: Frederic Konrad [mailto:fred.kon...@greensocs.com] On 22/10/2014 13:38, Pavel Dovgalyuk wrote: Hi Pavel, This patch fixes instructions counting w

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2014-10-23 Thread Pavel Dovgaluk
> From: Frederic Konrad [mailto:fred.kon...@greensocs.com] > On 23/10/2014 07:57, Pavel Dovgaluk wrote: > >> From: Frederic Konrad [mailto:fred.kon...@greensocs.com] > >> On 22/10/2014 13:38, Pavel Dovgalyuk wrote: > >> > >> Hi Pavel, > >>> This patch fixes instructions counting when execution is s

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2014-10-23 Thread Frederic Konrad
On 23/10/2014 07:57, Pavel Dovgaluk wrote: From: Frederic Konrad [mailto:fred.kon...@greensocs.com] On 22/10/2014 13:38, Pavel Dovgalyuk wrote: Hi Pavel, This patch fixes instructions counting when execution is stopped on breakpoint (e.g. set from gdb). Without a patch extra instruction is tran

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2014-10-22 Thread Pavel Dovgaluk
> From: Frederic Konrad [mailto:fred.kon...@greensocs.com] > On 22/10/2014 13:38, Pavel Dovgalyuk wrote: > > Hi Pavel, > > This patch fixes instructions counting when execution is stopped on > > breakpoint (e.g. set from gdb). Without a patch extra instruction is > > translated > > and icount is

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2014-10-22 Thread Frederic Konrad
On 22/10/2014 13:38, Pavel Dovgalyuk wrote: Hi Pavel, This patch fixes instructions counting when execution is stopped on breakpoint (e.g. set from gdb). Without a patch extra instruction is translated and icount is incremented by invalid value (which equals to number of executed instructions +

[Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2014-10-22 Thread Pavel Dovgalyuk
This patch fixes instructions counting when execution is stopped on breakpoint (e.g. set from gdb). Without a patch extra instruction is translated and icount is incremented by invalid value (which equals to number of executed instructions + 1). Signed-off-by: Pavel Dovgalyuk --- target-i386/tra