Re: [Qemu-devel] [PATCH] ide: coverity touchups

2015-07-14 Thread John Snow
On 07/14/2015 04:30 AM, Paolo Bonzini wrote: > > > On 13/07/2015 21:41, John Snow wrote: >> s->ports should never exceed 32, but coverity doesn't know that. >> ncq_tfs->sector_count should also never exceed 64K. Personally I tend to mark that kind of thing as a false posi

Re: [Qemu-devel] [PATCH] ide: coverity touchups

2015-07-14 Thread Paolo Bonzini
On 13/07/2015 21:41, John Snow wrote: >>> >> s->ports should never exceed 32, but coverity doesn't know that. >>> >> ncq_tfs->sector_count should also never exceed 64K. >> > >> > Personally I tend to mark that kind of thing as a false >> > positive in the coverity UI and move on... >> > >> > --

Re: [Qemu-devel] [PATCH] ide: coverity touchups

2015-07-13 Thread John Snow
On 07/13/2015 03:40 PM, Peter Maydell wrote: > On 13 July 2015 at 20:26, John Snow wrote: >> Just a handful of casts to quiet coverity up. >> >> s->ports should never exceed 32, but coverity doesn't know that. >> ncq_tfs->sector_count should also never exceed 64K. > > Personally I tend to mark

Re: [Qemu-devel] [PATCH] ide: coverity touchups

2015-07-13 Thread Peter Maydell
On 13 July 2015 at 20:26, John Snow wrote: > Just a handful of casts to quiet coverity up. > > s->ports should never exceed 32, but coverity doesn't know that. > ncq_tfs->sector_count should also never exceed 64K. Personally I tend to mark that kind of thing as a false positive in the coverity UI

[Qemu-devel] [PATCH] ide: coverity touchups

2015-07-13 Thread John Snow
Just a handful of casts to quiet coverity up. s->ports should never exceed 32, but coverity doesn't know that. ncq_tfs->sector_count should also never exceed 64K. Why not make Coverity a happy camper, though. Signed-off-by: John Snow --- hw/ide/ahci.c | 8 hw/ide/macio.c | 2 +- 2 fi