Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-23 Thread Juan Quintela
Peter Maydell peter.mayd...@linaro.org wrote: On 22 November 2011 11:06, Juan Quintela quint...@redhat.com wrote: Peter Chubb pet...@gelato.unsw.edu.au wrote:       vmstate_register(dev-qdev, -1, vmstate_imxg_timer, s); ??? Any particular reason to prefer a vmstate_register() call over

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-22 Thread Juan Quintela
Peter Chubb pet...@gelato.unsw.edu.au wrote: Hi Peter, Please find appended a patch containing initial support for the FreeScale i.MX31 and the KZM Arm11 evaluation board. The implementation was originally written by Hans Jang and Adam Clench of OK-Labs; I've updated it to the

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-22 Thread Peter Maydell
On 22 November 2011 11:06, Juan Quintela quint...@redhat.com wrote: Peter Chubb pet...@gelato.unsw.edu.au wrote: Hi Peter,    Please find appended a patch containing initial support for the    FreeScale i.MX31 and the KZM Arm11 evaluation board.    The implementation was originally written

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-22 Thread Peter Chubb
Juan == Juan Quintela quint...@redhat.com writes: Juan Peter Chubb pet...@gelato.unsw.edu.au wrote: Juan This is not used. Shouldn't a call like this be needed? Juanvmstate_register(dev-qdev, -1, vmstate_imxg_timer, s); Juan ??? Yes!! Thanks for checking. I've altered the source

[Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Chubb
Hi Peter, Please find appended a patch containing initial support for the FreeScale i.MX31 and the KZM Arm11 evaluation board. The implementation was originally written by Hans Jang and Adam Clench of OK-Labs; I've updated it to the current qdev and memory region paradigms and

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Andreas Färber
Hi Peter, Am 21.11.2011 22:58, schrieb Peter Chubb: Hi Peter, Please find appended a patch containing initial support for the FreeScale i.MX31 and the KZM Arm11 evaluation board. Your patch format is a bit unusual. Please don't include personal messages in the description, keep it in a

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Chubb
Andreas == Andreas Färber andreas.faer...@web.de writes: Andreas Hi Peter, Am 21.11.2011 22:58, schrieb Peter Chubb: Hi Peter, Please find appended a patch containing initial support for the FreeScale i.MX31 and the KZM Arm11 evaluation board. Andreas Your patch format is a bit unusual.

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Maydell
On 21 November 2011 23:04, Peter Chubb peter.ch...@nicta.com.au wrote: Andreas == Andreas Färber andreas.faer...@web.de writes: ??? Save/restore.  */ Andreas What does this comment tell us? :) Dunno.  It was in the codebase I got; I think it means that save and restore aren't implemented

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Maydell
On 21 November 2011 21:58, Peter Chubb pet...@gelato.unsw.edu.au wrote: Hi Peter,   Please find appended a patch containing initial support for the   FreeScale i.MX31 and the KZM Arm11 evaluation board.   The implementation was originally written by Hans Jang and Adam   Clench of OK-Labs;

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Chubb
Thanks Peter, I'll split the patches and resubmit. It'll probably be tomorrow or Thursday. Do you have a suggestion for an alternative to hw_error for guest bad behaviour? It seems to be used historically. For emulating ARM, causing qemu to stop isn't such a bad idea ... the guest does

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Maydell
On 21 November 2011 23:54, Peter Chubb pet...@gelato.unsw.edu.au wrote: Do you have a suggestion for an alternative to hw_error for guest bad behaviour?  It seems to be used historically.  For emulating ARM, causing qemu to stop isn't such a bad idea ... the guest does something wrong and the

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Maydell
On 22 November 2011 00:27, Peter Chubb peter.ch...@nicta.com.au wrote: Peter == Peter Maydell peter.mayd...@linaro.org writes: Peter On 21 November 2011 23:54, Peter Chubb Peter pet...@gelato.unsw.edu.au wrote: Do you have a suggestion for an alternative to hw_error for guest bad behaviour?  

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Chubb
Peter == Peter Maydell peter.mayd...@linaro.org writes: Peter On 21 November 2011 23:54, Peter Chubb Peter pet...@gelato.unsw.edu.au wrote: Do you have a suggestion for an alternative to hw_error for guest bad behaviour?  It seems to be used historically.  For emulating ARM, causing qemu to