Re: [Qemu-devel] [PATCH] input-keymap.c: Add keypad equal and power keys

2016-03-03 Thread Peter Maydell
On 3 March 2016 at 17:55, Programmingkid wrote: > > On Mar 3, 2016, at 10:49 AM, Gerd Hoffmann wrote: >> Of course, when emulating a x86 guest with ps/2 keyboard you still run >> into the problem that there might be no ps/2 scancode for certain keys. >> But there is nothing we can do about that.

Re: [Qemu-devel] [PATCH] input-keymap.c: Add keypad equal and power keys

2016-03-03 Thread Programmingkid
On Mar 3, 2016, at 10:49 AM, Gerd Hoffmann wrote: > Hi, > >>> number is modeled after pc scancodes, so you can't just pick random >>> numbers. >> >> Really? I thought the only requirement was each scancode had to be unique. > > No, it's not. ps2 emulation assumes those codes are the real on

Re: [Qemu-devel] [PATCH] input-keymap.c: Add keypad equal and power keys

2016-03-03 Thread Gerd Hoffmann
Hi, > > number is modeled after pc scancodes, so you can't just pick random > > numbers. > > Really? I thought the only requirement was each scancode had to be unique. No, it's not. ps2 emulation assumes those codes are the real ones. > > So, if there are no scancodes for the keys you want

Re: [Qemu-devel] [PATCH] input-keymap.c: Add keypad equal and power keys

2016-03-03 Thread Programmingkid
On Mar 3, 2016, at 5:01 AM, Gerd Hoffmann wrote: > On Mi, 2016-03-02 at 11:29 -0500, Programmingkid wrote: >> On Mar 2, 2016, at 11:12 AM, Gerd Hoffmann wrote: >> >>> On Mi, 2016-03-02 at 10:52 -0500, Programmingkid wrote: Add the keypad equals and power keys to the qcode_to_number array. T

Re: [Qemu-devel] [PATCH] input-keymap.c: Add keypad equal and power keys

2016-03-03 Thread Gerd Hoffmann
On Mi, 2016-03-02 at 11:29 -0500, Programmingkid wrote: > On Mar 2, 2016, at 11:12 AM, Gerd Hoffmann wrote: > > > On Mi, 2016-03-02 at 10:52 -0500, Programmingkid wrote: > >> Add the keypad equals and power keys to the qcode_to_number array. These > >> keys > >> are used on a Macintosh keyboard.

Re: [Qemu-devel] [PATCH] input-keymap.c: Add keypad equal and power keys

2016-03-02 Thread Programmingkid
On Mar 2, 2016, at 11:12 AM, Gerd Hoffmann wrote: > On Mi, 2016-03-02 at 10:52 -0500, Programmingkid wrote: >> Add the keypad equals and power keys to the qcode_to_number array. These keys >> are used on a Macintosh keyboard. >> >> Signed-off-by: John Arbuckle >> >> --- >> ui/input-keymap.c |

Re: [Qemu-devel] [PATCH] input-keymap.c: Add keypad equal and power keys

2016-03-02 Thread Programmingkid
On Mar 2, 2016, at 11:15 AM, Eric Blake wrote: > On 03/02/2016 08:52 AM, Programmingkid wrote: >> Add the keypad equals and power keys to the qcode_to_number array. These keys >> are used on a Macintosh keyboard. >> >> Signed-off-by: John Arbuckle >> >> --- >> ui/input-keymap.c |3 ++- >> 1

Re: [Qemu-devel] [PATCH] input-keymap.c: Add keypad equal and power keys

2016-03-02 Thread Eric Blake
On 03/02/2016 08:52 AM, Programmingkid wrote: > Add the keypad equals and power keys to the qcode_to_number array. These keys > are used on a Macintosh keyboard. > > Signed-off-by: John Arbuckle > > --- > ui/input-keymap.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) This pat

Re: [Qemu-devel] [PATCH] input-keymap.c: Add keypad equal and power keys

2016-03-02 Thread Gerd Hoffmann
On Mi, 2016-03-02 at 10:52 -0500, Programmingkid wrote: > Add the keypad equals and power keys to the qcode_to_number array. These keys > are used on a Macintosh keyboard. > > Signed-off-by: John Arbuckle > > --- > ui/input-keymap.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH] input-keymap.c: Add keypad equal and power keys

2016-03-02 Thread Programmingkid
Add the keypad equals and power keys to the qcode_to_number array. These keys are used on a Macintosh keyboard. Signed-off-by: John Arbuckle --- ui/input-keymap.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/ui/input-keymap.c b/ui/input-keymap.c index fd2c09d..8cff