Re: [Qemu-devel] [PATCH] ioapic: when switches to level trigger mode, interrupts raised repeatedly.

2011-04-03 Thread Aurelien Jarno
On Wed, Mar 16, 2011 at 06:05:01PM +0900, Isaku Yamahata wrote: - the trigger mode is edge at first - During initializatoin, the interrupt is raised as edge which is masked. The corresponding bit of irr is set. - Then the mode is switched to level and it's unmasked. - the bit of irr is set,

Re: [Qemu-devel] [PATCH] ioapic: when switches to level trigger mode, interrupts raised repeatedly.

2011-04-03 Thread Isaku Yamahata
Thank you for applying. But I found that the patch is wrong and I'm preparing the new one. Can you please revert it? On Sun, Apr 03, 2011 at 09:53:14PM +0200, Aurelien Jarno wrote: On Wed, Mar 16, 2011 at 06:05:01PM +0900, Isaku Yamahata wrote: - the trigger mode is edge at first - During

Re: [Qemu-devel] [PATCH] ioapic: when switches to level trigger mode, interrupts raised repeatedly.

2011-04-03 Thread Isaku Yamahata
On Mon, Apr 04, 2011 at 08:42:07AM +0900, Isaku Yamahata wrote: Thank you for applying. But I found that the patch is wrong and I'm preparing the new one. Can you please revert it? Here is the corrected patch. The first wrong patch clears the interrupts bit unconditionally. Which caused losing

Re: [Qemu-devel] [PATCH] ioapic: when switches to level trigger mode, interrupts raised repeatedly.

2011-04-03 Thread Aurelien Jarno
On Mon, Apr 04, 2011 at 08:42:07AM +0900, Isaku Yamahata wrote: Thank you for applying. But I found that the patch is wrong and I'm preparing the new one. Can you please revert it? Reverted for now, I'll ait for some comments on the new patch. On Sun, Apr 03, 2011 at 09:53:14PM +0200,

[Qemu-devel] [PATCH] ioapic: when switches to level trigger mode, interrupts raised repeatedly.

2011-03-16 Thread Isaku Yamahata
- the trigger mode is edge at first - During initializatoin, the interrupt is raised as edge which is masked. The corresponding bit of irr is set. - Then the mode is switched to level and it's unmasked. - the bit of irr is set, so the interrupt is raised repeatedly by ioapic_service(). - OS