Markus Armbruster wrote:
The commit message is bogus. The patch is a minor fix of commit
e8ee28fb, and the message is a copy of that commit's message.
Thanks, I've updated the commit message appropriately.
Regards,
Anthony Liguori
Gerd Hoffmann writes:
> This patch adds a 'index' property to the isa-parallel and isa-serial
> devices. This can be used to create devices with the default isa irqs
> and ioports by simply specifying the index, i.e.
>
>-device isa-serial,index=1
>
> instead of
>
>-device isa-serial,ioba
This patch adds a 'index' property to the isa-parallel and isa-serial
devices. This can be used to create devices with the default isa irqs
and ioports by simply specifying the index, i.e.
-device isa-serial,index=1
instead of
-device isa-serial,iobase=0x2f8,irq=3
for ttyS1 aka com2. Li
This patch adds a 'index' property to the isa-parallel and isa-serial
devices. This can be used to create devices with the default isa irqs
and ioports by simply specifying the index, i.e.
-device isa-serial,index=1
instead of
-device isa-serial,iobase=0x2f8,irq=3
for ttyS1 aka com2. Li
Looks fine to me. A similar solution could do for default mac address.
One little thing I missed on first reading: making an index property
hexadecimal is weird. I'd really expect decimal there.
Indeed. Wasn't intentional, cut+paste bug. Will fix.
cheers,
Gerd
Markus Armbruster writes:
> Gerd Hoffmann writes:
>
>> This patch adds a 'index' property to the isa-parallel and isa-serial
>> devices. This can be used to create devices with the default isa irqs
>> and ioports by simply specifying the index, i.e.
>>
>>-device isa-serial,index=1
>>
>> ins