[Qemu-devel] [PATCH] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-06 Thread Eric Blake
When qemu uses iscsi devices in sg mode, iscsilun->block_size is left at 0. Prior to commits cf081fca and similar, when block limits were tracked in sectors, this did not matter: various block limits were just left at 0. But when we started scaling by block size, this caused SIGFPE. One possible

Re: [Qemu-devel] [PATCH] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-06 Thread Holger Schranz
Hi Eric, I will test this patch within tomorrow. Is this o.k. for you? Beste regards Holger Am 06.09.2016 um 21:04 schrieb Eric Blake: When qemu uses iscsi devices in sg mode, iscsilun->block_size is left at 0. Prior to commits cf081fca and similar, when block limits were tracked in sectors,

Re: [Qemu-devel] [PATCH] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-07 Thread Kevin Wolf
Am 06.09.2016 um 21:04 hat Eric Blake geschrieben: > When qemu uses iscsi devices in sg mode, iscsilun->block_size > is left at 0. Prior to commits cf081fca and similar, when > block limits were tracked in sectors, this did not matter: > various block limits were just left at 0. But when we start

Re: [Qemu-devel] [PATCH] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-07 Thread Holger Schranz
Hello Eric, Kevin, unfortunately it was not possible for me to get the git tree at this time. I have insert the changes by hand, which was into this mail below in block/iscsi.c in the distribution from qemu.org for 2.7 (was this o.k.)? After installing and start with virsh create, the following

Re: [Qemu-devel] [PATCH] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-07 Thread Eric Blake
On 09/07/2016 06:48 AM, Holger Schranz wrote: > Hello Eric, Kevin, > > unfortunately it was not possible for me to get the git tree at this > time. I have insert the changes by hand, which was into this mail below > in block/iscsi.c in the distribution from qemu.org for 2.7 (was this o.k.)? Proba