Re: [Qemu-devel] [PATCH] iscsi: Remove pointless runtime check of macro value

2015-05-28 Thread Michael Tokarev
13.05.2015 16:15, Fam Zheng wrote: raw_bsd already has QEMU_BUILD_BUG_ON(BDRV_SECTOR_SIZE != 512), so iscsi should relax. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] iscsi: Remove pointless runtime check of macro value

2015-05-13 Thread Paolo Bonzini
On 13/05/2015 15:15, Fam Zheng wrote: raw_bsd already has QEMU_BUILD_BUG_ON(BDRV_SECTOR_SIZE != 512), so iscsi should relax. It's okay to have the same QEMU_BUILD_BUG_ON in different places. However, you're right that this should be a compile-time check rather than run-time check. Paolo

Re: [Qemu-devel] [PATCH] iscsi: Remove pointless runtime check of macro value

2015-05-13 Thread Fam Zheng
On Wed, 05/13 10:43, Paolo Bonzini wrote: On 13/05/2015 15:15, Fam Zheng wrote: raw_bsd already has QEMU_BUILD_BUG_ON(BDRV_SECTOR_SIZE != 512), so iscsi should relax. It's okay to have the same QEMU_BUILD_BUG_ON in different places. However, you're right that this should be a

[Qemu-devel] [PATCH] iscsi: Remove pointless runtime check of macro value

2015-05-12 Thread Fam Zheng
raw_bsd already has QEMU_BUILD_BUG_ON(BDRV_SECTOR_SIZE != 512), so iscsi should relax. Signed-off-by: Fam Zheng f...@redhat.com --- block/iscsi.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 8fca1d3..14e97a6 100644 --- a/block/iscsi.c +++