Re: [Qemu-devel] [PATCH] json-streamer: Don't leak tokens on incomplete parse

2016-07-04 Thread Paolo Bonzini
On 04/07/2016 14:21, Markus Armbruster wrote: > Double free. Can't see offhand how this stuff works. Eric, let's > revert this patch unless you can see a fix. I think I have a fix. Paolo

Re: [Qemu-devel] [PATCH] json-streamer: Don't leak tokens on incomplete parse

2016-07-04 Thread Markus Armbruster
Changlong Xie writes: > On 05/19/2016 05:46 AM, Eric Blake wrote: >> Valgrind complained about a number of leaks in >> tests/check-qobject-json: >> >> ==12657==definitely lost: 17,247 bytes in 1,234 blocks >> >> All of which had the same root cause: on an incomplete parse, >> we were abandoni

Re: [Qemu-devel] [PATCH] json-streamer: Don't leak tokens on incomplete parse

2016-07-04 Thread Changlong Xie
On 05/19/2016 05:46 AM, Eric Blake wrote: Valgrind complained about a number of leaks in tests/check-qobject-json: ==12657==definitely lost: 17,247 bytes in 1,234 blocks All of which had the same root cause: on an incomplete parse, we were abandoning the token queue without cleaning up the

Re: [Qemu-devel] [PATCH] json-streamer: Don't leak tokens on incomplete parse

2016-05-31 Thread Markus Armbruster
Eric Blake writes: > Valgrind complained about a number of leaks in > tests/check-qobject-json: > > ==12657==definitely lost: 17,247 bytes in 1,234 blocks > > All of which had the same root cause: on an incomplete parse, > we were abandoning the token queue without cleaning up the > allocated

[Qemu-devel] [PATCH] json-streamer: Don't leak tokens on incomplete parse

2016-05-18 Thread Eric Blake
Valgrind complained about a number of leaks in tests/check-qobject-json: ==12657==definitely lost: 17,247 bytes in 1,234 blocks All of which had the same root cause: on an incomplete parse, we were abandoning the token queue without cleaning up the allocated data within each queue element. I